Re: [PATCH 11/17] MIPS: Netlogic: Fix XLP9XX pic entry

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 04/29/2014 06:37 PM, Jayachandran C wrote:

> Add the compatible property to the PIC entry. Also fix up the nodename
> to use the correct address.

> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
>   arch/mips/netlogic/dts/xlp_gvp.dts |    5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

> diff --git a/arch/mips/netlogic/dts/xlp_gvp.dts b/arch/mips/netlogic/dts/xlp_gvp.dts
> index 047d27f..bb4ecd1 100644
> --- a/arch/mips/netlogic/dts/xlp_gvp.dts
> +++ b/arch/mips/netlogic/dts/xlp_gvp.dts
> @@ -26,11 +26,12 @@
>   			interrupt-parent = <&pic>;
>   			interrupts = <17>;
>   		};
> -		pic: pic@4000 {
> -			interrupt-controller;
> +		pic: pic@110000 {

    According to the ePAPR standard [1], the node name should be 
"interrupt-controller@110000".

> +			compatible = "netlogic,xlp-pic";
>   			#address-cells = <0>;
>   			#interrupt-cells = <1>;
>   			reg = <0 0x110000 0x200>;
> +			interrupt-controller;
>   		};

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei