From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 631EEC71136 for ; Thu, 12 Jun 2025 13:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HJ6W7ONfd3B0fKV4Ska0mkb9ZyQ2o0en1Prq02isjKg=; b=AKWaXqUXug6iIzDzrA9TRzT6ZW Gancv28f6LqZXNKRGEL8PtUcmjWeUyamIygvQkUk3Z7qkp/LjezZZRMLBsDKXxAXr9XbYirGqqawL AjBRrnEg9adhQaE+xZFPMOimG/HgLXTVl2g8U0TQkbnYjl574sl/2ndNGuz4OSVb7GaLi+pE8dF2Y 0c75VyDLuRBF+D+nc/TB2D9F2OFiHZDICJeg4/kV+DNZkcKEvRdz4K2lFUwc1DUhrMAPSTMQflexf MVYczTnvrhPAz+cz6debxrOkJYBfDg4NmTo5sMNcovQRRPA6yZTGxSBQP3SuUlzI6NcpRd5MBJkub 6W9kW4HQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPhpp-0000000DMzt-3kyB; Thu, 12 Jun 2025 13:19:13 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPfjZ-0000000D5gr-3HuG; Thu, 12 Jun 2025 11:04:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1749726275; bh=+Ccw5JM2ysrP6p18gVlHfA/xuzZsyf6EShm65BKIUU4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=crVdHEJHZ49tKIM6cQp/sxc/UxQS0Md/A9mrs7WZOkhjq8cTDVp3bXd251kYyZ9ES tIru8QtPCoM+ymTaCYPFVysC2oVFi+IWaKpPZfvhinNeiK5m/MPEGeljYEtCZktkcy KU/RZjdrlRcTyhYOfuZNW+BAyPF1ZiTWe6B4ypKVOqwE9ROhDjFRYIpllSyfFapLc5 PMpW7jgXnYZwdrN5Ju3TXOQLHo4Saa6z6zyWdwl9RBrZd9JPyLu0lF5pMa1py3aSEU dHQqmCoTgonMIG6DgcPYqqpehYKSSSwQBV09hbO0Vc6wdyXdncNZKGfflK2gF50f3d QtXM5Fq6DOJJg== Received: from [192.168.1.90] (unknown [212.93.144.165]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2B0D417E088C; Thu, 12 Jun 2025 13:04:35 +0200 (CEST) Message-ID: <535a4e1c-33d3-4941-8315-df20d4dec799@collabora.com> Date: Thu, 12 Jun 2025 14:04:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add HDMI PHY PLL clock source to VOP2 on rk3576 To: Piotr Oniszczuk Cc: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , kernel@collabora.com, Andy Yan , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250612-rk3576-hdmitx-fix-v1-0-4b11007d8675@collabora.com> <20250612-rk3576-hdmitx-fix-v1-3-4b11007d8675@collabora.com> <01D5D2D8-392B-4926-884E-1A4FB87C03CF@gmail.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <01D5D2D8-392B-4926-884E-1A4FB87C03CF@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250612_040437_973283_095E8BAC X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/12/25 1:22 PM, Piotr Oniszczuk wrote: > > >> Wiadomość napisana przez Cristian Ciocaltea w dniu 11 cze 2025, o godz. 23:47: >> >> Since commit c871a311edf0 ("phy: rockchip: samsung-hdptx: Setup TMDS >> char rate via phy_configure_opts_hdmi"), the workaround of passing the >> rate from DW HDMI QP bridge driver via phy_set_bus_width() became >> partially broken, as it cannot reliably handle mode switches anymore. >> >> Attempting to fix this up at PHY level would not only introduce >> additional hacks, but it would also fail to adequately resolve the >> display issues that are a consequence of the system CRU limitations. >> >> Instead, proceed with the solution already implemented for RK3588: make >> use of the HDMI PHY PLL as a better suited DCLK source for VOP2. This >> will not only address the aforementioned problem, but it should also >> facilitate the proper operation of display modes up to 4K@60Hz. >> >> It's worth noting that anything above 4K@30Hz still requires high TMDS >> clock ratio and scrambling support, which hasn't been mainlined yet. >> >> Fixes: d74b842cab08 ("arm64: dts: rockchip: Add vop for rk3576") >> Cc: stable@vger.kernel.org >> Signed-off-by: Cristian Ciocaltea >> --- >> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi >> index 6a13fe0c3513fb2ff7cd535aa70e3386c37696e4..b1ac23035dd789f0478bf10c78c74ef167d94904 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi >> @@ -1155,12 +1155,14 @@ vop: vop@27d00000 { >> <&cru HCLK_VOP>, >> <&cru DCLK_VP0>, >> <&cru DCLK_VP1>, >> - <&cru DCLK_VP2>; >> + <&cru DCLK_VP2>, >> + <&hdptxphy>; >> clock-names = "aclk", >> "hclk", >> "dclk_vp0", >> "dclk_vp1", >> - "dclk_vp2"; >> + "dclk_vp2", >> + "pll_hdmiphy0"; >> iommus = <&vop_mmu>; >> power-domains = <&power RK3576_PD_VOP>; >> rockchip,grf = <&sys_grf>; >> >> -- >> 2.49.0 >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip > > Cristian, > It fixes fractional hd modes for me on rk3576. > Thx for this fix! Thanks for testing! :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FDB3C61CE8 for ; Thu, 12 Jun 2025 13:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6S9A4+lKRBRurFgL6qviKYOejT8shTn0zAANPgh+G/E=; b=cIjGb5OYGPbqTw xNe3kmsO3tvbeoIWE4prrRogLga/FoIS63BdNbiUnunEwe4T8e00RZcIjprynokxjiH+yiXLua9KY /7H4YZtf9/dRXbOe5EmOOZjxpl7b2FYhFIJesRIGjBFHgtW2k0PRYJb0420BNaH1KEa5l/h2OtdFp Gt9iXEkty/eR9WXWLVoZmbi88DOZuo7iid/Egq4n8rR2+vw7d4ONR+QTek1AeJAsrZMZTkAdoHSWB vQHXIbBwj9vFTo4WQhLJyVaxmfRqvL1dp5XXmTqxNBFNq671EbFK67tpQ+cW5Q4G0Hj9bFyiWHQuz XeJIMoyMZjkQAhEI3Ujw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPhpq-0000000DN2D-42MV; Thu, 12 Jun 2025 13:19:14 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPfjZ-0000000D5gr-3HuG; Thu, 12 Jun 2025 11:04:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1749726275; bh=+Ccw5JM2ysrP6p18gVlHfA/xuzZsyf6EShm65BKIUU4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=crVdHEJHZ49tKIM6cQp/sxc/UxQS0Md/A9mrs7WZOkhjq8cTDVp3bXd251kYyZ9ES tIru8QtPCoM+ymTaCYPFVysC2oVFi+IWaKpPZfvhinNeiK5m/MPEGeljYEtCZktkcy KU/RZjdrlRcTyhYOfuZNW+BAyPF1ZiTWe6B4ypKVOqwE9ROhDjFRYIpllSyfFapLc5 PMpW7jgXnYZwdrN5Ju3TXOQLHo4Saa6z6zyWdwl9RBrZd9JPyLu0lF5pMa1py3aSEU dHQqmCoTgonMIG6DgcPYqqpehYKSSSwQBV09hbO0Vc6wdyXdncNZKGfflK2gF50f3d QtXM5Fq6DOJJg== Received: from [192.168.1.90] (unknown [212.93.144.165]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2B0D417E088C; Thu, 12 Jun 2025 13:04:35 +0200 (CEST) Message-ID: <535a4e1c-33d3-4941-8315-df20d4dec799@collabora.com> Date: Thu, 12 Jun 2025 14:04:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add HDMI PHY PLL clock source to VOP2 on rk3576 To: Piotr Oniszczuk Cc: Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , kernel@collabora.com, Andy Yan , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250612-rk3576-hdmitx-fix-v1-0-4b11007d8675@collabora.com> <20250612-rk3576-hdmitx-fix-v1-3-4b11007d8675@collabora.com> <01D5D2D8-392B-4926-884E-1A4FB87C03CF@gmail.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <01D5D2D8-392B-4926-884E-1A4FB87C03CF@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250612_040437_973283_095E8BAC X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gNi8xMi8yNSAxOjIyIFBNLCBQaW90ciBPbmlzemN6dWsgd3JvdGU6Cj4gCj4gCj4+IFdpYWRv bW/Fm8SHIG5hcGlzYW5hIHByemV6IENyaXN0aWFuIENpb2NhbHRlYSA8Y3Jpc3RpYW4uY2lvY2Fs dGVhQGNvbGxhYm9yYS5jb20+IHcgZG5pdSAxMSBjemUgMjAyNSwgbyBnb2R6LiAyMzo0NzoKPj4K Pj4gU2luY2UgY29tbWl0IGM4NzFhMzExZWRmMCAoInBoeTogcm9ja2NoaXA6IHNhbXN1bmctaGRw dHg6IFNldHVwIFRNRFMKPj4gY2hhciByYXRlIHZpYSBwaHlfY29uZmlndXJlX29wdHNfaGRtaSIp LCB0aGUgd29ya2Fyb3VuZCBvZiBwYXNzaW5nIHRoZQo+PiByYXRlIGZyb20gRFcgSERNSSBRUCBi cmlkZ2UgZHJpdmVyIHZpYSBwaHlfc2V0X2J1c193aWR0aCgpIGJlY2FtZQo+PiBwYXJ0aWFsbHkg YnJva2VuLCBhcyBpdCBjYW5ub3QgcmVsaWFibHkgaGFuZGxlIG1vZGUgc3dpdGNoZXMgYW55bW9y ZS4KPj4KPj4gQXR0ZW1wdGluZyB0byBmaXggdGhpcyB1cCBhdCBQSFkgbGV2ZWwgd291bGQgbm90 IG9ubHkgaW50cm9kdWNlCj4+IGFkZGl0aW9uYWwgaGFja3MsIGJ1dCBpdCB3b3VsZCBhbHNvIGZh aWwgdG8gYWRlcXVhdGVseSByZXNvbHZlIHRoZQo+PiBkaXNwbGF5IGlzc3VlcyB0aGF0IGFyZSBh IGNvbnNlcXVlbmNlIG9mIHRoZSBzeXN0ZW0gQ1JVIGxpbWl0YXRpb25zLgo+Pgo+PiBJbnN0ZWFk LCBwcm9jZWVkIHdpdGggdGhlIHNvbHV0aW9uIGFscmVhZHkgaW1wbGVtZW50ZWQgZm9yIFJLMzU4 ODogbWFrZQo+PiB1c2Ugb2YgdGhlIEhETUkgUEhZIFBMTCBhcyBhIGJldHRlciBzdWl0ZWQgRENM SyBzb3VyY2UgZm9yIFZPUDIuIFRoaXMKPj4gd2lsbCBub3Qgb25seSBhZGRyZXNzIHRoZSBhZm9y ZW1lbnRpb25lZCBwcm9ibGVtLCBidXQgaXQgc2hvdWxkIGFsc28KPj4gZmFjaWxpdGF0ZSB0aGUg cHJvcGVyIG9wZXJhdGlvbiBvZiBkaXNwbGF5IG1vZGVzIHVwIHRvIDRLQDYwSHouCj4+Cj4+IEl0 J3Mgd29ydGggbm90aW5nIHRoYXQgYW55dGhpbmcgYWJvdmUgNEtAMzBIeiBzdGlsbCByZXF1aXJl cyBoaWdoIFRNRFMKPj4gY2xvY2sgcmF0aW8gYW5kIHNjcmFtYmxpbmcgc3VwcG9ydCwgd2hpY2gg aGFzbid0IGJlZW4gbWFpbmxpbmVkIHlldC4KPj4KPj4gRml4ZXM6IGQ3NGI4NDJjYWIwOCAoImFy bTY0OiBkdHM6IHJvY2tjaGlwOiBBZGQgdm9wIGZvciByazM1NzYiKQo+PiBDYzogc3RhYmxlQHZn ZXIua2VybmVsLm9yZwo+PiBTaWduZWQtb2ZmLWJ5OiBDcmlzdGlhbiBDaW9jYWx0ZWEgPGNyaXN0 aWFuLmNpb2NhbHRlYUBjb2xsYWJvcmEuY29tPgo+PiAtLS0KPj4gYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9yazM1NzYuZHRzaSB8IDYgKysrKy0tCj4+IDEgZmlsZSBjaGFuZ2VkLCA0IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0 L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU3Ni5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazM1NzYuZHRzaQo+PiBpbmRleCA2YTEzZmUwYzM1MTNmYjJmZjdjZDUzNWFhNzBlMzM4 NmMzNzY5NmU0Li5iMWFjMjMwMzVkZDc4OWYwNDc4YmYxMGM3OGM3NGVmMTY3ZDk0OTA0IDEwMDY0 NAo+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU3Ni5kdHNpCj4+ICsr KyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTc2LmR0c2kKPj4gQEAgLTExNTUs MTIgKzExNTUsMTQgQEAgdm9wOiB2b3BAMjdkMDAwMDAgewo+PiA8JmNydSBIQ0xLX1ZPUD4sCj4+ IDwmY3J1IERDTEtfVlAwPiwKPj4gPCZjcnUgRENMS19WUDE+LAo+PiAtIDwmY3J1IERDTEtfVlAy PjsKPj4gKyA8JmNydSBEQ0xLX1ZQMj4sCj4+ICsgPCZoZHB0eHBoeT47Cj4+IGNsb2NrLW5hbWVz ID0gImFjbGsiLAo+PiAgICAgICJoY2xrIiwKPj4gICAgICAiZGNsa192cDAiLAo+PiAgICAgICJk Y2xrX3ZwMSIsCj4+IC0gICAgICAiZGNsa192cDIiOwo+PiArICAgICAgImRjbGtfdnAyIiwKPj4g KyAgICAgICJwbGxfaGRtaXBoeTAiOwo+PiBpb21tdXMgPSA8JnZvcF9tbXU+Owo+PiBwb3dlci1k b21haW5zID0gPCZwb3dlciBSSzM1NzZfUERfVk9QPjsKPj4gcm9ja2NoaXAsZ3JmID0gPCZzeXNf Z3JmPjsKPj4KPj4gLS0gCj4+IDIuNDkuMAo+Pgo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QK Pj4gTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwo+PiBodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCj4gCj4gQ3Jpc3RpYW4s Cj4gSXQgZml4ZXMgZnJhY3Rpb25hbCBoZCBtb2RlcyBmb3IgbWUgb24gcmszNTc2Lgo+IFRoeCBm b3IgdGhpcyBmaXghCgpUaGFua3MgZm9yIHRlc3RpbmchIDopCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QK TGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==