From mboxrd@z Thu Jan  1 00:00:00 1970
From: "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] mbcache: LLVMLinux: Remove double calculation from mbcache
Date: Tue, 29 Apr 2014 22:19:17 -0700
Message-ID: <536087D5.1040409@zytor.com>
References: <1398820239-1890-1-git-send-email-behanw@converseincode.com> <a54957c1-4825-4265-8126-4565168fe8c6@email.android.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, dwmw2@infradead.org,
	Mark Charlebois <charlebm@gmail.com>
To: behanw@converseincode.com, viro@zeniv.linux.org.uk
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <a54957c1-4825-4265-8126-4565168fe8c6@email.android.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On 04/29/2014 06:13 PM, H. Peter Anvin wrote:
> I suspect this will generate FP instructions on x86 which will corrupt user space state.  This is thus a critical bug!!

It looks like at least x86-64 gcc does the evaluation at compile time
and there aren't any fp instructions left in the code. However, it
should still be fixed.

	-hpa