From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <juergen.gross@ts.fujitsu.com>
Subject: Re: Hidden symbol when debugging hypervisor
Date: Wed, 30 Apr 2014 11:39:31 +0200
Message-ID: <5360C4D3.3010000@ts.fujitsu.com>
References: <2039026.XfIYG36Q6e@amur> <5360C1DC.9020707@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5360C1DC.9020707@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>, Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 30.04.2014 11:26, George Dunlap wrote:
> On 04/30/2014 10:02 AM, Dietmar Hahn wrote:
>> Hi,
>>
>> while debugging a vmcore with the crash tool I stumpled over a little pr=
oblem.
>> I wanted to look at the "struct csched_private" of credit scheduler and =
got
>> the contents of the "struct csched_private" of credit2.
>> The debug informations of the hypervisor contain 2 entries
>>   <1><b185e>: Abbrev Number: 8 (DW_TAG_structure_type)
>>      <b185f>   DW_AT_name        : (indirect string, offset: 0x9d8d):
>> csched_private
>> and
>>   <1><c0677>: Abbrev Number: 25 (DW_TAG_structure_type)
>>      <c0678>   DW_AT_name        : (indirect string, offset: 0x9d8d):
>> csched_private
>>
>> The first is credit and the second credit2. It seems in the crash comman=
d the
>> second entry wins :-(.
>>
>> Maybe crash has the possibility somewhere to get access to the second st=
ructure
>> (I couldn't find it) but for simplicity it would be better to have diffe=
rent
>> names
>> I think.
>> Are there any reasons not to rename
>> struct csched_private -> struct c2sched_private
>> or whatever?
>
> No reasons at all -- the naming is an artifact of development.  Feel free=
 to
> send a patch renaming it.

I tried it once: http://lists.xen.org/archives/html/xen-devel/2013-02/msg02=
255.html

Jan didn't like it.


J=FCrgen

-- =

Juergen Gross                 Principal Developer Operating Systems
PSO PM&D ES&S SWE OS6                  Telephone: +49 (0) 89 62060 2932
Fujitsu                                   e-mail: juergen.gross@ts.fujitsu.=
com
Mies-van-der-Rohe-Str. 8                Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.ht=
ml