From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: Hidden symbol when debugging hypervisor
Date: Wed, 30 Apr 2014 11:07:28 +0100
Message-ID: <5360CB60.7000704@eu.citrix.com>
References: <2039026.XfIYG36Q6e@amur> <5360C1DC.9020707@eu.citrix.com>
	<5360C4D3.3010000@ts.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5360C4D3.3010000@ts.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <juergen.gross@ts.fujitsu.com>, Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 04/30/2014 10:39 AM, Juergen Gross wrote:
> On 30.04.2014 11:26, George Dunlap wrote:
>> On 04/30/2014 10:02 AM, Dietmar Hahn wrote:
>>> Hi,
>>>
>>> while debugging a vmcore with the crash tool I stumpled over a 
>>> little problem.
>>> I wanted to look at the "struct csched_private" of credit scheduler 
>>> and got
>>> the contents of the "struct csched_private" of credit2.
>>> The debug informations of the hypervisor contain 2 entries
>>>   <1><b185e>: Abbrev Number: 8 (DW_TAG_structure_type)
>>>      <b185f>   DW_AT_name        : (indirect string, offset: 0x9d8d):
>>> csched_private
>>> and
>>>   <1><c0677>: Abbrev Number: 25 (DW_TAG_structure_type)
>>>      <c0678>   DW_AT_name        : (indirect string, offset: 0x9d8d):
>>> csched_private
>>>
>>> The first is credit and the second credit2. It seems in the crash 
>>> command the
>>> second entry wins :-(.
>>>
>>> Maybe crash has the possibility somewhere to get access to the 
>>> second structure
>>> (I couldn't find it) but for simplicity it would be better to have 
>>> different
>>> names
>>> I think.
>>> Are there any reasons not to rename
>>> struct csched_private -> struct c2sched_private
>>> or whatever?
>>
>> No reasons at all -- the naming is an artifact of development. Feel 
>> free to
>> send a patch renaming it.
>
> I tried it once: 
> http://lists.xen.org/archives/html/xen-devel/2013-02/msg02255.html
>
> Jan didn't like it.

It looks like he was only thinking about backtraces, not about cscope or 
about debugging core dumps.  Jan, do you have another solution for 
those, or shall we go ahead and change the names?

  -George