All of lore.kernel.org
 help / color / mirror / Atom feed
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] sched_clock: also call register_current_timer_delay() if possible
Date: Wed, 30 Apr 2014 15:01:32 +0200	[thread overview]
Message-ID: <5360F42C.9080401@linutronix.de> (raw)
In-Reply-To: <20140430124800.GC21876@arm.com>

On 04/30/2014 02:48 PM, Will Deacon wrote:
> Hi Sebastian,

Hi Will,

> As long as sched_clock is guaranteed to be a fixed frequency, always-on
> clocksource then this could work, but it removes the flexibility of having
> a separate delay clock and sched clock (is this useful?).



> Looking at your patch, I noticed that we need to extend the
> register_current_timer_delay function to deal with clocks that aren't as
> wide as cycle_t, otherwise we don't delay() for long enough when the clock
> overflows (this is potentially already an issue for architected timers <
> 64-bit). Could you cook a patch for that please?

Sure, I would change the type from long to u64 and fix all users. Would
that be okay for you?

> 
> Will

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Will Deacon <will.deacon@arm.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	John Stultz <john.stultz@linaro.org>,
	Theodore Ts o <tytso@mit.edu>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH] sched_clock: also call register_current_timer_delay() if possible
Date: Wed, 30 Apr 2014 15:01:32 +0200	[thread overview]
Message-ID: <5360F42C.9080401@linutronix.de> (raw)
In-Reply-To: <20140430124800.GC21876@arm.com>

On 04/30/2014 02:48 PM, Will Deacon wrote:
> Hi Sebastian,

Hi Will,

> As long as sched_clock is guaranteed to be a fixed frequency, always-on
> clocksource then this could work, but it removes the flexibility of having
> a separate delay clock and sched clock (is this useful?).



> Looking at your patch, I noticed that we need to extend the
> register_current_timer_delay function to deal with clocks that aren't as
> wide as cycle_t, otherwise we don't delay() for long enough when the clock
> overflows (this is potentially already an issue for architected timers <
> 64-bit). Could you cook a patch for that please?

Sure, I would change the type from long to u64 and fix all users. Would
that be okay for you?

> 
> Will

Sebastian

  reply	other threads:[~2014-04-30 13:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 12:23 [RFC PATCH] sched_clock: also call register_current_timer_delay() if possible Sebastian Andrzej Siewior
2014-04-30 12:23 ` Sebastian Andrzej Siewior
2014-04-30 12:48 ` Will Deacon
2014-04-30 12:48   ` Will Deacon
2014-04-30 13:01   ` Sebastian Andrzej Siewior [this message]
2014-04-30 13:01     ` Sebastian Andrzej Siewior
2014-04-30 13:26     ` Will Deacon
2014-04-30 13:26       ` Will Deacon
2014-04-30 16:56       ` Sebastian Andrzej Siewior
2014-04-30 16:56         ` Sebastian Andrzej Siewior
2014-05-02 16:50         ` Will Deacon
2014-05-02 16:50           ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5360F42C.9080401@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.