All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 03/11] board: controlcenterd: Use new API for setting i2c bus
Date: Wed, 30 Apr 2014 16:31:48 +0200	[thread overview]
Message-ID: <53610954.3030109@denx.de> (raw)
In-Reply-To: <1398865804-12539-4-git-send-email-dirk.eibach@gdsys.cc>

Hello Dirk,

Am 30.04.2014 15:49, schrieb dirk.eibach at gdsys.cc:
> From: Dirk Eibach<dirk.eibach@gdsys.cc>
>
> Signed-off-by: Dirk Eibach<dirk.eibach@gdsys.cc>
> ---
>
>   board/gdsys/p1022/controlcenterd-id.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/board/gdsys/p1022/controlcenterd-id.c b/board/gdsys/p1022/controlcenterd-id.c
> index 3fca3c5..019df5e 100644
> --- a/board/gdsys/p1022/controlcenterd-id.c
> +++ b/board/gdsys/p1022/controlcenterd-id.c
> @@ -1189,8 +1189,8 @@ int startup_ccdm_id_module(void)
>   	int result = 0;
>   	unsigned int orig_i2c_bus;
>
> -	orig_i2c_bus = I2C_GET_BUS();
> -	I2C_SET_BUS(1);
> +	orig_i2c_bus = i2c_get_bus_num();
> +	i2c_set_bus_num(1);

Nitpicking: Can you replace the "1" with a define?

If all i2c drivers switched to the new API, we can get rid of this
"storing from old i2c bus" mechanism complete ... but as this is not
done yet:

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-04-30 14:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 13:49 [U-Boot] [PATCH v1 0/11] Fixes on gdsys boards and some new functionality dirk.eibach at gdsys.cc
2014-04-30 13:49 ` [U-Boot] [PATCH v1 01/11] board: controlcenterd: Fix pci access dirk.eibach at gdsys.cc
2014-04-30 13:49 ` [U-Boot] [PATCH v1 02/11] board: gdsys: Adapt sdhc_boot.c to mmc_get_env_addr API change dirk.eibach at gdsys.cc
2014-04-30 13:49 ` [U-Boot] [PATCH v1 03/11] board: controlcenterd: Use new API for setting i2c bus dirk.eibach at gdsys.cc
2014-04-30 14:31   ` Heiko Schocher [this message]
2014-04-30 13:49 ` [U-Boot] [PATCH v1 04/11] board: iocon: Support DisplayPort hardware dirk.eibach at gdsys.cc
2014-04-30 13:49 ` [U-Boot] [PATCH v1 05/11] board: gdsys: IHS I2C master driver dirk.eibach at gdsys.cc
2014-04-30 14:42   ` Heiko Schocher
2014-04-30 13:49 ` [U-Boot] [PATCH v1 06/11] board: gdsys: Increase iocon and dlv10g version string dirk.eibach at gdsys.cc
2014-04-30 13:50 ` [U-Boot] [PATCH v1 07/11] board: gdsys: Configure bridge on DP501 to support DDC only dirk.eibach at gdsys.cc
2014-04-30 13:50 ` [U-Boot] [PATCH v1 08/11] board: gdsys: Make gdsys osd hardware detection more robust dirk.eibach at gdsys.cc
2014-04-30 13:50 ` [U-Boot] [PATCH v1 09/11] board: gdsys: Enable scrambling on DP501 dirk.eibach at gdsys.cc
2014-04-30 13:50 ` [U-Boot] [PATCH v1 10/11] board: iocon: Modify iocon hardware startup dirk.eibach at gdsys.cc
2014-04-30 13:50 ` [U-Boot] [PATCH v1 11/11] board: gdsys: Remove commands to reduce footprint dirk.eibach at gdsys.cc
2014-04-30 14:45   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53610954.3030109@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.