All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput
Date: Wed, 30 Apr 2014 10:02:52 -0500	[thread overview]
Message-ID: <5361109C.4000502@sandeen.net> (raw)
In-Reply-To: <53610DA7.8070806@sgi.com>

On 4/30/14, 9:50 AM, Mark Tinguely wrote:
> On 04/30/14 09:47, Eric Sandeen wrote:
>> On 4/30/14, 8:48 AM, Mark Tinguely wrote:
>>> >  Remove the unused second argument to xfs_iput() and
>>> >  xfs_trans_iput().
>>> >
>>> >  Introduce the define "IRELE()" and use in place of xfs_iput().
>> Why do this?  We had been moving away from the upper-case-macro-
>> redefined-to-a-function meme... what does this #define gain?
>>
>> libxfs_iget/libxfs_iput pairs seem more obvious than
>> libxfs_iget/IRELE()...
>>
>> Thanks,
>> -Eric
>>
> 
> To be consistent with the kernel code.

Gah, hohum, I'm not even going to try to explain why I thought
we didn't have it in kernel code.

sorry for the noise,
-Eric

> --Mark.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-04-30 15:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 13:48 [PATCH 0/2] xfsprog: fix xfs_inode lifetime issue Mark Tinguely
2014-04-30 13:48 ` [PATCH 1/2] xfsprogs: remove unused argument in trans_iput Mark Tinguely
2014-04-30 14:47   ` Eric Sandeen
2014-04-30 14:50     ` Mark Tinguely
2014-04-30 15:02       ` Eric Sandeen [this message]
2014-04-30 15:10     ` Christoph Hellwig
2014-04-30 15:10   ` Christoph Hellwig
2014-04-30 13:48 ` [PATCH 2/2] xfsprogs: dont free xfs_inode until complete Mark Tinguely
2014-04-30 15:14   ` Christoph Hellwig
2014-05-01 23:33 ` [PATCH 0/2] xfsprog: fix xfs_inode lifetime issue Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5361109C.4000502@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.