* [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
@ 2014-04-30 3:06 Hui Wang
2014-04-30 10:37 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Hui Wang @ 2014-04-30 3:06 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: david.henningsson, stable, hui.wang
When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
SID: 0x1028067e), the headset mic can't be detected, after apply this
patch, the headset mic can work well.
BugLink: https://bugs.launchpad.net/bugs/1297581
Cc: David Henningsson <david.henningsson@canonical.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e96ab33..b60de0d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4711,6 +4711,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1028, 0x067e, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
2014-04-30 3:06 [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop Hui Wang
@ 2014-04-30 10:37 ` Takashi Iwai
2014-04-30 15:32 ` David Henningsson
0 siblings, 1 reply; 10+ messages in thread
From: Takashi Iwai @ 2014-04-30 10:37 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, david.henningsson, stable
At Wed, 30 Apr 2014 11:06:00 +0800,
Hui Wang wrote:
>
> When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
> SID: 0x1028067e), the headset mic can't be detected, after apply this
> patch, the headset mic can work well.
>
> BugLink: https://bugs.launchpad.net/bugs/1297581
> Cc: David Henningsson <david.henningsson@canonical.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Thanks, applied.
But now I'm slowly thinking of cleaning these messes; can't we detect
this a bit more elegantly?
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e96ab33..b60de0d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4711,6 +4711,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> + SND_PCI_QUIRK(0x1028, 0x067e, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
2014-04-30 10:37 ` Takashi Iwai
@ 2014-04-30 15:32 ` David Henningsson
2014-04-30 16:06 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: David Henningsson @ 2014-04-30 15:32 UTC (permalink / raw)
To: Takashi Iwai, Hui Wang; +Cc: alsa-devel
(Drop stable from cc)
On 2014-04-30 12:37, Takashi Iwai wrote:
> At Wed, 30 Apr 2014 11:06:00 +0800,
> Hui Wang wrote:
>>
>> When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
>> SID: 0x1028067e), the headset mic can't be detected, after apply this
>> patch, the headset mic can work well.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1297581
>> Cc: David Henningsson <david.henningsson@canonical.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>
> Thanks, applied.
>
> But now I'm slowly thinking of cleaning these messes; can't we detect
> this a bit more elegantly?
I've been thinking of that too. I'm wondering if the combination of
vendor (Dell), codec (e g ALC255), and pin config could be wise here? I
e, if all of the pin configuration default values are exactly the same,
then we should be reasonably sure that it is to be used in the same way.
So, essentially have a quirk table with PCI Subvendor + codec + pin
config as key? What do you think of that?
>
>
> Takashi
>
>> ---
>> sound/pci/hda/patch_realtek.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index e96ab33..b60de0d 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -4711,6 +4711,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>> SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>> + SND_PCI_QUIRK(0x1028, 0x067e, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
>> --
>> 1.8.1.2
>>
>
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
2014-04-30 15:32 ` David Henningsson
@ 2014-04-30 16:06 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2014-04-30 16:06 UTC (permalink / raw)
To: David Henningsson; +Cc: Hui Wang, alsa-devel
At Wed, 30 Apr 2014 17:32:04 +0200,
David Henningsson wrote:
>
> (Drop stable from cc)
>
> On 2014-04-30 12:37, Takashi Iwai wrote:
> > At Wed, 30 Apr 2014 11:06:00 +0800,
> > Hui Wang wrote:
> >>
> >> When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
> >> SID: 0x1028067e), the headset mic can't be detected, after apply this
> >> patch, the headset mic can work well.
> >>
> >> BugLink: https://bugs.launchpad.net/bugs/1297581
> >> Cc: David Henningsson <david.henningsson@canonical.com>
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> >
> > Thanks, applied.
> >
> > But now I'm slowly thinking of cleaning these messes; can't we detect
> > this a bit more elegantly?
>
> I've been thinking of that too. I'm wondering if the combination of
> vendor (Dell), codec (e g ALC255), and pin config could be wise here? I
> e, if all of the pin configuration default values are exactly the same,
> then we should be reasonably sure that it is to be used in the same way.
>
> So, essentially have a quirk table with PCI Subvendor + codec + pin
> config as key? What do you think of that?
This sounds feasible to me.
Takashi
>
> >
> >
> > Takashi
> >
> >> ---
> >> sound/pci/hda/patch_realtek.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> >> index e96ab33..b60de0d 100644
> >> --- a/sound/pci/hda/patch_realtek.c
> >> +++ b/sound/pci/hda/patch_realtek.c
> >> @@ -4711,6 +4711,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> >> SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> >> SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> >> SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> >> + SND_PCI_QUIRK(0x1028, 0x067e, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> >> SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> >> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> >> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> >> --
> >> 1.8.1.2
> >>
> >
>
> --
> David Henningsson, Canonical Ltd.
> https://launchpad.net/~diwic
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
@ 2014-04-28 6:45 Hui Wang
2014-04-28 10:15 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Hui Wang @ 2014-04-28 6:45 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: david.henningsson, stable, hui.wang
When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
SID: 0x10280674), the headset mic can't be detected, after apply this
patch, the headset mic can work well.
BugLink: https://bugs.launchpad.net/bugs/1297581
Cc: David Henningsson <david.henningsson@canonical.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c643dfc..c1952c9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4621,6 +4621,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
2014-04-28 6:45 Hui Wang
@ 2014-04-28 10:15 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2014-04-28 10:15 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, david.henningsson, stable
At Mon, 28 Apr 2014 14:45:00 +0800,
Hui Wang wrote:
>
> When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
> SID: 0x10280674), the headset mic can't be detected, after apply this
> patch, the headset mic can work well.
>
> BugLink: https://bugs.launchpad.net/bugs/1297581
> Cc: David Henningsson <david.henningsson@canonical.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Thanks, applied.
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index c643dfc..c1952c9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4621,6 +4621,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> + SND_PCI_QUIRK(0x1028, 0x0674, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
@ 2014-04-16 2:09 Hui Wang
2014-04-16 5:48 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Hui Wang @ 2014-04-16 2:09 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: david.henningsson, stable, hui.wang
When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
SID: 0x1028067f), the headset mic can't be detected, after apply this
patch, the headset mic can work well.
BugLink: https://bugs.launchpad.net/bugs/1297581
Cc: David Henningsson <david.henningsson@canonical.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f7766fe..26895d1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4621,6 +4621,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
2014-04-16 2:09 Hui Wang
@ 2014-04-16 5:48 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2014-04-16 5:48 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, david.henningsson, stable
At Wed, 16 Apr 2014 10:09:08 +0800,
Hui Wang wrote:
>
> When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0255,
> SID: 0x1028067f), the headset mic can't be detected, after apply this
> patch, the headset mic can work well.
>
> BugLink: https://bugs.launchpad.net/bugs/1297581
> Cc: David Henningsson <david.henningsson@canonical.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Thanks, applied.
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f7766fe..26895d1 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4621,6 +4621,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> + SND_PCI_QUIRK(0x1028, 0x067f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
@ 2014-04-09 8:01 Hui Wang
2014-04-09 8:06 ` Takashi Iwai
0 siblings, 1 reply; 10+ messages in thread
From: Hui Wang @ 2014-04-09 8:01 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: david.henningsson, stable, hui.wang
When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0283,
SID: 0x10280667), the headset mic can't be detected, after apply this
patch, the headset mic can work well.
BugLink: https://bugs.launchpad.net/bugs/1297581
Cc: David Henningsson <david.henningsson@canonical.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0d72dbf..14ae979 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4618,6 +4618,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x0658, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x065f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0662, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop
2014-04-09 8:01 Hui Wang
@ 2014-04-09 8:06 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2014-04-09 8:06 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, david.henningsson, stable
At Wed, 9 Apr 2014 16:01:01 +0800,
Hui Wang wrote:
>
> When we plug a 3-ring headset on the Dell machine (VID: 0x10ec0283,
> SID: 0x10280667), the headset mic can't be detected, after apply this
> patch, the headset mic can work well.
>
> BugLink: https://bugs.launchpad.net/bugs/1297581
> Cc: David Henningsson <david.henningsson@canonical.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Applied (after removing the doubled sign-offs). Thanks.
Takashi
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 0d72dbf..14ae979 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4618,6 +4618,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1028, 0x0658, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x065f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0662, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> + SND_PCI_QUIRK(0x1028, 0x0667, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0668, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x0669, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-04-30 16:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-30 3:06 [PATCH] ALSA: hda - add headset mic detect quirk for a Dell laptop Hui Wang
2014-04-30 10:37 ` Takashi Iwai
2014-04-30 15:32 ` David Henningsson
2014-04-30 16:06 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2014-04-28 6:45 Hui Wang
2014-04-28 10:15 ` Takashi Iwai
2014-04-16 2:09 Hui Wang
2014-04-16 5:48 ` Takashi Iwai
2014-04-09 8:01 Hui Wang
2014-04-09 8:06 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.