From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: vcpu: Correctly release resource when the VCPU failed to initialized Date: Wed, 30 Apr 2014 20:09:14 +0100 Message-ID: <53614A5A.7060906@linaro.org> References: <1398881159-10640-1-git-send-email-julien.grall@linaro.org> <53613D10.2010901@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WfZsc-0007BK-7W for xen-devel@lists.xenproject.org; Wed, 30 Apr 2014 19:09:18 +0000 Received: by mail-wg0-f44.google.com with SMTP id a1so628178wgh.15 for ; Wed, 30 Apr 2014 12:09:16 -0700 (PDT) In-Reply-To: <53613D10.2010901@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org Hi Andrew, On 30/04/14 19:12, Andrew Cooper wrote: > On 30/04/14 19:05, Julien Grall wrote: >> While I was adding new failing code at the end of the function, I've noticed >> that the vtimers are not freed which mess all the timers and will crash Xen >> quickly when the page will be reused. >> >> Currently none of vcpu_vgic_init and vcpu_vtimer_init doesn't failed, so we > > This sentence is confusing. Do you mean "Currently neither > vcpu_vgic_init nor vcpu_vtimer_init fail, so we..." ? Yes, I will update the commit message on the next version. Regards, -- Julien Grall