From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 13F5C14007D for ; Thu, 1 May 2014 06:06:10 +1000 (EST) Message-ID: <536157AC.6000901@suse.de> Date: Wed, 30 Apr 2014 22:06:04 +0200 From: Alexander Graf MIME-Version: 1.0 To: Stuart Yoder , "benh@kernel.crashing.org" , Scott Wood Subject: Re: [PATCH] powerpc: move epapr paravirt init of power_save to an initcall References: <1398887641-20705-1-git-send-email-stuart.yoder@freescale.com> <5361556D.7080805@suse.de> <33939d8249c34c8fb694da3e94196211@DM2PR03MB352.namprd03.prod.outlook.com> In-Reply-To: <33939d8249c34c8fb694da3e94196211@DM2PR03MB352.namprd03.prod.outlook.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 30.04.14 22:03, Stuart Yoder wrote: > >> -----Original Message----- >> From: Alexander Graf [mailto:agraf@suse.de] >> Sent: Wednesday, April 30, 2014 2:56 PM >> To: Yoder Stuart-B08248; benh@kernel.crashing.org; Wood Scott-B07421 >> Cc: linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH] powerpc: move epapr paravirt init of power_save to >> an initcall >> >> >> On 30.04.14 21:54, Stuart Yoder wrote: >>> From: Stuart Yoder >>> >>> some restructuring of epapr paravirt init resulted in >>> ppc_md.power_save being set, and then overwritten to >>> NULL during machine_init. This patch splits the >>> initialization of ppc_md.power_save out into a postcore >>> init call. >>> >>> Signed-off-by: Stuart Yoder >>> --- >>> arch/powerpc/kernel/epapr_paravirt.c | 25 ++++++++++++++++++++----- >>> 1 file changed, 20 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/powerpc/kernel/epapr_paravirt.c >> b/arch/powerpc/kernel/epapr_paravirt.c >>> index 6300c13..c49b69c 100644 >>> --- a/arch/powerpc/kernel/epapr_paravirt.c >>> +++ b/arch/powerpc/kernel/epapr_paravirt.c >>> @@ -52,11 +52,6 @@ static int __init early_init_dt_scan_epapr(unsigned >> long node, >>> #endif >>> } >>> >>> -#if !defined(CONFIG_64BIT) || defined(CONFIG_PPC_BOOK3E_64) >>> - if (of_get_flat_dt_prop(node, "has-idle", NULL)) >>> - ppc_md.power_save = epapr_ev_idle; >>> -#endif >>> - >>> epapr_paravirt_enabled = true; >>> >>> return 1; >>> @@ -69,3 +64,23 @@ int __init epapr_paravirt_early_init(void) >>> return 0; >>> } >>> >>> +static int __init epapr_idle_init_dt_scan(unsigned long node, >>> + const char *uname, >>> + int depth, void *data) >>> +{ >>> +#if !defined(CONFIG_64BIT) || defined(CONFIG_PPC_BOOK3E_64) >>> + if (of_get_flat_dt_prop(node, "has-idle", NULL)) >>> + ppc_md.power_save = epapr_ev_idle; >>> +#endif >>> + return 0; >>> +} >>> + >>> +static int __init epapr_idle_init(void) >>> +{ >>> + if (epapr_paravirt_enabled) >>> + of_scan_flat_dt(epapr_idle_init_dt_scan, NULL); >> Doesn't this scan all nodes? We only want to match on >> /hypervisor/has-idle, no? > I cut/pasted from the approach the existing code in that file > took, but yes you're right we just need the one property. > Let me respin that to look at the hypervisor node only. The other function aborts early if it doesn't find a "hcall-instructions" property. I'm still surprised we don't limit the scope to /hypervisor at all though. Is this on purpose maybe? Alex