All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Raghavendra Ganiga <ravi23ganiga@gmail.com>,
	<hsweeten@visionengravers.com>, <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: fix coding style issues in comedi_fops.c
Date: Thu, 1 May 2014 10:01:35 +0100	[thread overview]
Message-ID: <53620D6F.1020808@mev.co.uk> (raw)
In-Reply-To: <1398879289-20442-1-git-send-email-ravi23ganiga@gmail.com>

On 2014/04/30 06:34 PM, Raghavendra Ganiga wrote:
> This is a patch to fix coding style
> warnings found by the checkpatch.pl tool
> 
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
> ---
>  drivers/staging/comedi/comedi_fops.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index acc8019..a62d639 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,15 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
>  	s = &dev->subdevices[cmd->subdev];
>  
>  	if (s->type == COMEDI_SUBD_UNUSED) {
> -		dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> +		dev_dbg(dev->class_dev, "%d not valid subdevice\n",
> +			cmd->subdev);
>  		return -EIO;
>  	}
>  
>  	if (!s->do_cmd || !s->do_cmdtest || !s->async) {
>  		dev_dbg(dev->class_dev,
> -			"subdevice %d does not support commands\n", cmd->subdev);
> +			"subdevice %d does not support commands\n",
> +			cmd->subdev);
>  		return -EIO;
>  	}

(I think this is "PATCH v2".)

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>             )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587              )=-

  parent reply	other threads:[~2014-05-01  9:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 17:34 [PATCH] staging: comedi: fix coding style issues in comedi_fops.c Raghavendra Ganiga
2014-04-30 19:59 ` Dan Carpenter
2014-05-01  9:01 ` Ian Abbott [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-01  8:23 Raghavendra Ganiga
2014-05-01  9:05 ` Ian Abbott
2014-04-25 17:50 RAGHAVENDRA GANIGA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53620D6F.1020808@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi23ganiga@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.