From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<xen-devel@lists.xen.org>
Subject: Re: [3.15-rc3] Bisected: xen-netback mangles packets between two guests on a bridge since merge of "TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy" series.
Date: Thu, 1 May 2014 14:49:45 +0100 [thread overview]
Message-ID: <536250F9.7060405@citrix.com> (raw)
In-Reply-To: <395225650.20140430124506@eikelenboom.it>
On 30/04/14 11:45, Sander Eikelenboom wrote:
> Another point would be: what *correctness* testing is actually done on the xen-net* patches ?
I can speak only about my patches: I have manually tested them for the
usecases where they likely to make a difference, plus they went through
Xenserver's full test suite several times.
> As i suspect this is again about fragmented packets .. that doesn't seem to be included in any test case while it actually seems to be a case which is hard to get right...
Beware, there are frags and frag_list which are two entirely different
things with confusing names. In netback case, frags are used to pass
through large packets for a long time. frag_list is used only since my
grant mapping patches, to handle older guests (see comment in
include/xen/interface/io/netif.h for XEN_NETIF_NR_SLOTS_MIN)
Zoli
next prev parent reply other threads:[~2014-05-01 13:49 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 10:45 [3.15-rc3] Bisected: xen-netback mangles packets between two guests on a bridge since merge of "TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy" series Sander Eikelenboom
2014-04-30 15:24 ` Eric Dumazet
2014-04-30 15:24 ` Eric Dumazet
2014-04-30 20:40 ` Zoltan Kiss
2014-04-30 20:40 ` Zoltan Kiss
2014-04-30 20:53 ` Zoltan Kiss
2014-04-30 22:25 ` Sander Eikelenboom
2014-05-01 13:37 ` Zoltan Kiss
2014-05-01 13:37 ` Zoltan Kiss
2014-05-01 13:59 ` Sander Eikelenboom
2014-05-01 13:59 ` Sander Eikelenboom
2014-05-01 15:46 ` Zoltan Kiss
2014-05-01 15:46 ` Zoltan Kiss
2014-05-01 17:39 ` Sander Eikelenboom
2014-05-01 17:46 ` Eric Dumazet
2014-05-01 17:46 ` Eric Dumazet
2014-05-01 19:39 ` [Xen-devel] " Sander Eikelenboom
2014-05-02 14:00 ` Zoltan Kiss
2014-05-02 14:06 ` Sander Eikelenboom
2014-05-02 14:06 ` [Xen-devel] " Sander Eikelenboom
2014-05-02 14:47 ` Zoltan Kiss
2014-05-02 15:21 ` Eric Dumazet
2014-05-02 15:21 ` [Xen-devel] " Eric Dumazet
2014-05-02 15:26 ` Zoltan Kiss
2014-05-02 16:28 ` Sander Eikelenboom
2014-05-02 16:28 ` [Xen-devel] " Sander Eikelenboom
2014-05-02 16:45 ` Zoltan Kiss
2014-05-05 10:19 ` Sander Eikelenboom
2014-05-05 10:19 ` [Xen-devel] " Sander Eikelenboom
2014-05-06 17:07 ` Steven Haigh
2014-05-06 17:07 ` Steven Haigh
2014-05-06 17:13 ` Zoltan Kiss
2014-05-06 17:13 ` Zoltan Kiss
2014-05-06 17:37 ` Sander Eikelenboom
2014-05-06 18:07 ` Steven Haigh
2014-05-07 8:16 ` David Vrabel
2014-05-07 8:16 ` [Xen-devel] " David Vrabel
2014-05-16 2:13 ` Steven Haigh
2014-05-16 2:13 ` Steven Haigh
2014-05-06 18:07 ` Steven Haigh
2014-05-06 17:08 ` Zoltan Kiss
2014-05-06 17:08 ` [Xen-devel] " Zoltan Kiss
2014-05-06 17:10 ` Zoltan Kiss
2014-05-06 17:10 ` [Xen-devel] " Zoltan Kiss
2014-05-06 17:33 ` Sander Eikelenboom
2014-05-02 16:45 ` Zoltan Kiss
2014-05-02 15:26 ` Zoltan Kiss
2014-05-02 14:47 ` Zoltan Kiss
2014-05-02 14:00 ` Zoltan Kiss
2014-05-01 19:39 ` Sander Eikelenboom
2014-05-01 17:39 ` Sander Eikelenboom
2014-04-30 22:25 ` Sander Eikelenboom
2014-04-30 20:53 ` Zoltan Kiss
2014-05-01 13:49 ` Zoltan Kiss [this message]
2014-05-01 14:05 ` Sander Eikelenboom
2014-05-01 14:05 ` Sander Eikelenboom
2014-05-01 15:16 ` Zoltan Kiss
2014-05-01 15:16 ` Zoltan Kiss
2014-05-01 15:40 ` Sander Eikelenboom
2014-05-01 15:40 ` Sander Eikelenboom
2014-05-02 15:35 ` Eric Dumazet
2014-05-02 15:35 ` Eric Dumazet
2014-05-02 22:18 ` Sander Eikelenboom
2014-05-02 22:18 ` Sander Eikelenboom
2014-05-09 22:19 ` Neal Cardwell
2014-05-09 22:19 ` Neal Cardwell
2014-05-01 13:49 ` Zoltan Kiss
2014-05-09 21:02 ` Zoltan Kiss
2014-05-09 21:02 ` Zoltan Kiss
2014-05-13 13:40 ` Zoltan Kiss
2014-05-13 13:40 ` Zoltan Kiss
-- strict thread matches above, loose matches on Subject: below --
2014-04-30 10:45 Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536250F9.7060405@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=davem@davemloft.net \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.