Re: [meta-qt5][PATCH] qtbase.inc: Enable accessibility by default

[Jonathan Liu <net147@gmail.com>]

On 29/04/2014 1:27 AM, Otavio Salvador wrote:
> qtdeclarative requires accessibility to be enabled and it is added by
> default to the toolchain so we ought to have it enabled to ensure the
> default toolchain generation works.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>   recipes-qt/qt5/qtbase.inc |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
> index 89736be..91cadef 100644
> --- a/recipes-qt/qt5/qtbase.inc
> +++ b/recipes-qt/qt5/qtbase.inc
> @@ -39,6 +39,7 @@ PACKAGECONFIG_X11 ?= "${@base_contains('DISTRO_FEATURES', 'x11', 'xcb xvideo xsy
>   PACKAGECONFIG_FONTS ?= ""
>   PACKAGECONFIG_SYSTEM ?= "jpeg libpng zlib"
>   PACKAGECONFIG_MULTIMEDIA ?= "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}"
> +PACKAGECONFIG_ACCESSIBILITY ?= "accessibility"
>   PACKAGECONFIG_DISTRO ?= ""
>   # Either release or debug, can be overridden in bbappends
>   PACKAGECONFIG_RELEASE ?= "release"
> @@ -56,6 +57,7 @@ PACKAGECONFIG ?= " \
>       ${PACKAGECONFIG_FONTS} \
>       ${PACKAGECONFIG_SYSTEM} \
>       ${PACKAGECONFIG_MULTIMEDIA} \
> +    ${PACKAGECONFIG_ACCESSIBILITY} \
>       ${PACKAGECONFIG_DISTRO} \
>   "
>   
I would change "qtdeclarative" to "qtquickcontrols" in the commit 
message to match the PACKAGECONFIG comment in qtbase.inc.
I think qtdeclarative might still compile fine without accessibility but 
you would have to check.

Regards,
Jonathan