diff for duplicates of <5362FDA9.8080300@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 816fbe3..e4fc816 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -38,7 +38,8 @@ On 05/01/2014 04:05 PM, Tomas Pop wrote: > +++ b/Documentation/hwmon/shtc1 > @@ -0,0 +1,38 @@ > +Kernel driver shtc1 -> +=========> + +> +=================== +> + > +Supported chips: > + * Sensirion SHTC1 > + Prefix: 'shtc1' @@ -317,7 +318,7 @@ Please make sure that the function always returns a valid error code. > + */ > + ret = !data->valid; -So ret gets pre-initialized with 1 if valid = 0. Doesn't really make sense. +So ret gets pre-initialized with 1 if valid == 0. Doesn't really make sense. Just initialize it with 0 above. int ret = 0; @@ -358,7 +359,7 @@ Just wondering .. what is in buf[2] and buf[5] ? > +out: > + mutex_unlock(&data->update_lock); > + -> + return ret = 0 ? data : ERR_PTR(ret); +> + return ret == 0 ? data : ERR_PTR(ret); > +} > + > +static ssize_t shtc1_show_temperature(struct device *dev, @@ -623,9 +624,3 @@ require devicetree support. Thanks, Guenter - - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 961b6fa..8a2f7fb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01398985530.17142.15.camel@ltli10.sensirion.lokal\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] [RFC][PATCH v2] hwmon: add support for Sensirion SHTC1 sensor\0" - "Date\0Fri, 02 May 2014 02:06:33 +0000\0" + "Subject\0Re: [RFC][PATCH v2] hwmon: add support for Sensirion SHTC1 sensor\0" + "Date\0Thu, 01 May 2014 19:06:33 -0700\0" "To\0Tomas Pop <tomas.pop.mff@gmail.com>" " jdelvare@suse.de <jdelvare@suse.de>\0" "Cc\0lm-sensors@lm-sensors.org" @@ -48,7 +48,8 @@ "> +++ b/Documentation/hwmon/shtc1\n" "> @@ -0,0 +1,38 @@\n" "> +Kernel driver shtc1\n" - "> +=========> +\n" + "> +===================\n" + "> +\n" "> +Supported chips:\n" "> + * Sensirion SHTC1\n" "> + Prefix: 'shtc1'\n" @@ -327,7 +328,7 @@ "> +\t*/\n" "> +\tret = !data->valid;\n" "\n" - "So ret gets pre-initialized with 1 if valid = 0. Doesn't really make sense.\n" + "So ret gets pre-initialized with 1 if valid == 0. Doesn't really make sense.\n" "Just initialize it with 0 above.\n" "\n" "\tint ret = 0;\n" @@ -368,7 +369,7 @@ "> +out:\n" "> +\tmutex_unlock(&data->update_lock);\n" "> +\n" - "> +\treturn ret = 0 ? data : ERR_PTR(ret);\n" + "> +\treturn ret == 0 ? data : ERR_PTR(ret);\n" "> +}\n" "> +\n" "> +static ssize_t shtc1_show_temperature(struct device *dev,\n" @@ -632,12 +633,6 @@ "require devicetree support.\n" "\n" "Thanks,\n" - "Guenter\n" - "\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Guenter -81b69577b71266ddd392afb2ce49609706974d5da0ebaac0c1c9bd700cffd093 +ce31fe067b0db0211b1c06d02712e69cebb1ac9fea56ffdef905f0ab001f49fa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.