From: Hans de Goede <hdegoede@redhat.com>
To: Zhang Rui <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
Josh Boyer <jwboyer@fedoraproject.org>
Subject: RFC: changing acpi-video brightness_switch_enabled default to 0
Date: Fri, 02 May 2014 11:32:15 +0200 [thread overview]
Message-ID: <5363661F.1050301@redhat.com> (raw)
Hi All,
I was already considering asking for $subject for a while, but I did not see
any bug reports caused by it so I didn't ask. Until today I discovered that
I'm not seeing any bugs because Fedora is carrying a kernel patch
changing the default.
A quick google search for brightness_switch_enabled OTOH reveals that for
other distros it is a serious problem, see ie:
https://bugs.launchpad.net/gnome-settings-daemon/+bug/527157
http://askubuntu.com/questions/173921/why-does-my-thinkpad-brightness-control-skip-steps
The problem is that acpi-video is unique in that it not only generates
brightness up/down keypresses, but also (sometimes) actively changes the
brightness itself.
This presents an inconsistent kernel interface to userspace, basically there
are 2 different scenarios, depending on the laptop model:
1) On some laptops a brightness up/down keypress means: show a brightness osd
with the current brightness, iow it is a brightness has changed notification.
2) Where as on (a lot of) other laptops it means a brightness up/down key was
pressed, deal with it.
Most of the desktop environments interpret any press as in scenario 2, and
change the brightness up / down as a response to the key events, causing it
to be changed twice, once by acpi-video and once by the DE.
With the new default for video.use_native_backlight we will be moving even
more laptops over to behaving as in scenario 2. Making the remaining laptops
even more of a weird exception. Also note that it is hard to detect scenario
1 properly in userspace, and AFAIK none of the DE-s deasls with it.
Therefor I would like to propose to change the brightness_switch_enabled
default to 0.
Regards,
Hans
next reply other threads:[~2014-05-02 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 9:32 Hans de Goede [this message]
2014-05-02 11:56 ` RFC: changing acpi-video brightness_switch_enabled default to 0 Rafael J. Wysocki
2014-05-04 2:55 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5363661F.1050301@redhat.com \
--to=hdegoede@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.