From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgCfd-00005c-7E for qemu-devel@nongnu.org; Fri, 02 May 2014 08:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgCfY-0006ol-8Z for qemu-devel@nongnu.org; Fri, 02 May 2014 08:34:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgCfX-0006oc-Vn for qemu-devel@nongnu.org; Fri, 02 May 2014 08:34:24 -0400 Message-ID: <536390CD.8070106@redhat.com> Date: Fri, 02 May 2014 06:34:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399030002-27222-1-git-send-email-armbru@redhat.com> <1399030002-27222-15-git-send-email-armbru@redhat.com> In-Reply-To: <1399030002-27222-15-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mtF06jAT3t3Sksrn0V9iil8WmXJ4V5TS9" Subject: Re: [Qemu-devel] [PATCH v3 14/14] qmp: Don't use error_is_set() to suppress additional errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mtF06jAT3t3Sksrn0V9iil8WmXJ4V5TS9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/02/2014 05:26 AM, Markus Armbruster wrote: > Using error_is_set(errp) that way can sweep programming errors under > the carpet when we get called incorrectly with an error set. >=20 > encrypted_bdrv_it() does it, because there's no way to make > bdrv_iterate() break its loop. Actually safe, because qmp_cont() > clears the error before the loop. Clean it up anyway: replace > bdrv_iterate() by bdrv_next(), break the loop on error. >=20 > Replace both occurences, for consistency. s/occurences/occurrences/ >=20 > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake Fixing up the commit message typo is trivial and doesn't alter the positive review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mtF06jAT3t3Sksrn0V9iil8WmXJ4V5TS9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTY5DNAAoJEKeha0olJ0Nqu3EIAJ0xiKANBWCmTIHfgYAjJx/7 3DLadM2Z6d9ZKJy4i2MXUTqEsvhjDYxZ6LSNjGFhC7+cUtR53BjbA2DnYOSFVtof yWg+bb5oYN+80k8npGtOuEoWEM7iC+CiYPaOpZPoOWLMo27/lANnRZZSd/E+KvaI 8Kys0MKywGMG1Kln5p2o2g5BjjVO7T9tklMfgBZbYBfOmSDr1ldzKizL8mUWwlRE pTBrBNUjnwRo4gtbkEdejvJEqNs1KTSzFoumSmr8/NIOrLSvi64aZ1MUpCqk6dAO NhpSKho53ukHZGXbXdjP8NKNykS5X9i7geq55sD1MFNZjeUNbbwCBNFDeSHn7+g= =UIiz -----END PGP SIGNATURE----- --mtF06jAT3t3Sksrn0V9iil8WmXJ4V5TS9--