From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: traps: Add missing 0x in bad_trap Date: Fri, 02 May 2014 14:25:57 +0100 Message-ID: <53639CE5.7020103@linaro.org> References: <1397130265-2389-1-git-send-email-julien.grall@linaro.org> <1399035362.32736.112.camel@kazak.uk.xensource.com> <53639B71.3050209@linaro.org> <1399036917.6043.3.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WgDTV-0000gP-F8 for xen-devel@lists.xenproject.org; Fri, 02 May 2014 13:26:01 +0000 Received: by mail-ee0-f51.google.com with SMTP id c13so3146644eek.24 for ; Fri, 02 May 2014 06:25:59 -0700 (PDT) In-Reply-To: <1399036917.6043.3.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Jan Beulich , stefano.stabellini@citrix.com, Andrew Cooper List-Id: xen-devel@lists.xenproject.org On 05/02/2014 02:21 PM, Ian Campbell wrote: > On Fri, 2014-05-02 at 14:19 +0100, Julien Grall wrote: >> On 05/02/2014 01:56 PM, Ian Campbell wrote: >>> On Thu, 2014-04-10 at 12:44 +0100, Julien Grall wrote: >>>> The syndrome value is printed in hexadecimal. Prefix it by 0x for less >>>> confusion. >>>> >>>> Signed-off-by: Julien Grall >>> >>> I've acked + applied this. Irrespective of any apparent move to prefer % >>> #x this is an improvement. >> >> Thanks. So what was the conclusion about % vs #x. Which one shall we use? > > I'm perfectly fine with 0x%x for ARM code. I think Andy's comment about > "Xen moving towards" was overstating things somewhat. Ok. FIY, Jan Beulich asked me to change some 0x%x into #x in common code when I sent patch a couple of month ago. -- Julien Grall