Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends

[Richard Henderson <rth7680@gmail.com>]

On 05/02/2014 09:30 AM, Ulrich Weigand wrote:
> Richard Henderson <rth7680@gmail.com> wrote on 01.05.2014 17:44:21:
> 
>> Please review, and if you've got an ELFv2 system (nudge nudge), please
>> give it a try and make sure it works.
> 
> I ran into illegal instructions due to this patch:
> 
>>   tcg-ppc64: Support mulsh_i32
> [snip]
>>     case INDEX_op_muluh_i32:
>>         tcg_out32(s, MULHWU | TAB(args[0], args[1], args[2]));
>>         break;
>> +    case INDEX_op_mulsh_i32:
>> +        tcg_out32(s, MULHW | TAB(args[1], args[2], args[3]));
>> +        break;
> 
> I guess that needs to be args[0], args[1], args[2] as well.
> 
> With that change, I was able to start both qemu-system-x86_64 and
> qemu-system-ppc64 and have them run through the respective BIOS/
> SLOF bootup sequence.

Whoops.  That what I get for rearranging the patches at the last minute.


r~