All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Beomho Seo <beomho.seo@samsung.com>,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Tomasz Figa <t.figa@samsung.com>,
	Kukjin Kim <kgene.kim@samsung.com>
Cc: Myungjoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412
Date: Fri, 02 May 2014 20:00:06 +0200	[thread overview]
Message-ID: <5363DD26.1020704@gmail.com> (raw)
In-Reply-To: <53633D4B.9070500@samsung.com>

Hi Beomho,

On 02.05.2014 08:38, Beomho Seo wrote:
> This patch fixed gpio key device node.
> First, fix incorrect gpio property.
> And then, add ok-key node where locate bottom center.
> I have tested on exynos4412-trats2 board.

While at it, could you also remove interrupt-parent and interrupts 
properties from nodes of the keys? They have been added here by a 
mistake and they are not part of the gpio-keys device tree bindings.

Best regards,
Tomasz

      reply	other threads:[~2014-05-02 18:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02  6:38 [PATCH v2 3/3] ARM: dts: fixed gpio key node for exynos4412 Beomho Seo
2014-05-02 18:00 ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5363DD26.1020704@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=beomho.seo@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.