From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Fri, 2 May 2014 17:14:24 -0700 Subject: [U-Boot] [Patch v4 1/2] common/board_f: Initialized global data for generic board In-Reply-To: References: <1398985240-23670-1-git-send-email-yorksun@freescale.com> Message-ID: <536434E0.70300@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/01/2014 07:45 PM, Simon Glass wrote: > On 1 May 2014 16:00, York Sun wrote: >> Some platforms (tested on mpc85xx, mpc86xx) use global data before calling >> function baord_inti_f(). The data should not be cleared later. Any arch >> which uses global data in generic board board_init_f() should define >> CONFIG_SYS_GENERIC_GLOBAL_DATA. >> >> Signed-off-by: York Sun >> CC: Scott Wood >> CC: Simon Glass >> CC: Albert ARIBAUD >> --- >> Change log >> >> v4: Replace with CONFIG_SYS_GENERIC_GLOBAL_DATA, a positive logic >> v3: Introduce CONFIG_SYS_EARLY_GD instead of using a list >> v2: Instead of adding back gd init for all PPC, preserve gd for mpc85xx and mpc86xx. >> >> README | 6 ++++++ >> arch/arc/include/asm/config.h | 2 ++ >> arch/arm/include/asm/config.h | 2 ++ >> arch/mips/include/asm/config.h | 2 ++ > > I think you will need sandbox also. Otherwise looks good. > > Reviewed-by: Simon Glass > Simon, Sandbox doesn't have CONFIG_SYS_GENERIC_BOARD defined yet. Did you convert it recently? York