From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: Add ABI documentation for illuminance
Date: Sat, 03 May 2014 11:45:09 +0100 [thread overview]
Message-ID: <5364C8B5.5080404@kernel.org> (raw)
In-Reply-To: <1399046089-6616-3-git-send-email-pmeerw@pmeerw.net>
On 02/05/14 16:54, Peter Meerwald wrote:
> has been in use for a long time, but never documented;
> state that this measurement should be in lux (drivers may feel
> different about this)
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
I agree that it should be in Lux.
Note that I was sure this was documented somewhere so went looking.
It was under drivers/staging/iio/Documentation/sysfs-bus-iio-light
Description agrees with yours so this patch is fine, but we should
drop the version in staging in favour of this.
Note that quite a few elements in that staging file are unlikely to
ever make it out of staging as they currently stand!
Thanks and applied to the togreg branch of iio.git
J
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 9669c1f..a9757dc 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -895,6 +895,15 @@ Description:
> on-chip EEPROM. After power-up or chip reset the device will
> automatically load the saved configuration.
>
> +What: /sys/.../iio:deviceX/in_illuminanceY_input
> +What: /sys/.../iio:deviceX/in_illuminanceY_raw
> +What: /sys/.../iio:deviceX/in_illuminanceY_mean_raw
> +KernelVersion: 3.4
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Illuminance measurement, units after application of scale
> + and offset are lux.
> +
> What: /sys/.../iio:deviceX/in_intensityY_raw
> What: /sys/.../iio:deviceX/in_intensityY_ir_raw
> What: /sys/.../iio:deviceX/in_intensityY_both_raw
>
next prev parent reply other threads:[~2014-05-03 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 15:54 [PATCH 0/4] iio: missing ABI documentation Peter Meerwald
2014-05-02 15:54 ` [PATCH 1/4] iio: Add intensity including ir and both modifiers to ABI documentation ex-post Peter Meerwald
2014-05-03 10:41 ` Jonathan Cameron
2014-05-02 15:54 ` [PATCH 2/4] iio: Add ABI documentation for illuminance Peter Meerwald
2014-05-03 10:45 ` Jonathan Cameron [this message]
2014-05-02 15:54 ` [PATCH 3/4] iio: Add ABI documentation for proximity Peter Meerwald
2014-05-03 10:48 ` Jonathan Cameron
2014-05-03 10:49 ` Jonathan Cameron
2014-05-02 15:54 ` [PATCH 4/4] iio: Fix spelling of illuminance in gp2ap020a00f driver Peter Meerwald
2014-05-03 10:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5364C8B5.5080404@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.