From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:54102 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbaECTiM (ORCPT ); Sat, 3 May 2014 15:38:12 -0400 Message-ID: <53654602.9080507@kernel.org> Date: Sat, 03 May 2014 20:39:46 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Srinivas Pandruvada CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 12/16] iio: hid-sensors: ALS: Raw read support References: <1397863356-2470-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1397863356-2470-12-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1397863356-2470-12-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 19/04/14 00:22, Srinivas Pandruvada wrote: > Added support for raw reading of channel. If the sensor is powered > off, it will turn on for reading value. > > Signed-off-by: Srinivas Pandruvada Applied to the togreg branch of iio.git Thanks, > --- > drivers/iio/light/hid-sensor-als.c | 24 +++++++++++++++++++----- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c > index e124b39..f34c943 100644 > --- a/drivers/iio/light/hid-sensor-als.c > +++ b/drivers/iio/light/hid-sensor-als.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -49,6 +50,7 @@ static const struct iio_chan_spec als_channels[] = { > .type = IIO_INTENSITY, > .modified = 1, > .channel2 = IIO_MOD_LIGHT_BOTH, > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), > .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) | > BIT(IIO_CHAN_INFO_SCALE) | > BIT(IIO_CHAN_INFO_SAMP_FREQ) | > @@ -79,6 +81,7 @@ static int als_read_raw(struct iio_dev *indio_dev, > u32 address; > int ret; > int ret_type; > + s32 poll_value; > > *val = 0; > *val2 = 0; > @@ -94,12 +97,23 @@ static int als_read_raw(struct iio_dev *indio_dev, > report_id = -1; > break; > } > - if (report_id >= 0) > + if (report_id >= 0) { > + poll_value = hid_sensor_read_poll_value( > + &als_state->common_attributes); > + if (poll_value < 0) > + return -EINVAL; > + > + hid_sensor_power_state(&als_state->common_attributes, > + true); > + msleep_interruptible(poll_value * 2); > + > *val = sensor_hub_input_attr_get_raw_value( > - als_state->common_attributes.hsdev, > - HID_USAGE_SENSOR_ALS, address, > - report_id); > - else { > + als_state->common_attributes.hsdev, > + HID_USAGE_SENSOR_ALS, address, > + report_id); > + hid_sensor_power_state(&als_state->common_attributes, > + false); > + } else { > *val = 0; > return -EINVAL; > } >