From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgtfA-0001Y6-85 for qemu-devel@nongnu.org; Sun, 04 May 2014 06:28:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wgtez-0003xS-53 for qemu-devel@nongnu.org; Sun, 04 May 2014 06:28:52 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:37975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgtey-0003x6-Vg for qemu-devel@nongnu.org; Sun, 04 May 2014 06:28:41 -0400 Received: by mail-pd0-f179.google.com with SMTP id g10so4735362pdj.10 for ; Sun, 04 May 2014 03:28:39 -0700 (PDT) Message-ID: <53661653.4020001@ozlabs.ru> Date: Sun, 04 May 2014 20:28:35 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1398741464-21394-1-git-send-email-aik@ozlabs.ru> <535F73AB.8010403@suse.de> In-Reply-To: <535F73AB.8010403@suse.de> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr_pci: Fix maximum IRQ number check in ibm, change-msi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-stable@nongnu.org On 04/29/2014 07:40 PM, Alexander Graf wrote: > > On 29.04.14 05:17, Alexey Kardashevskiy wrote: >> Recently a check for maximum supported MSIX vectors number has been >> added. However the check always assumed that MSIX is the only case >> and failed on devices which have MSI but do not have MSIX such as >> QEMU's PCI Bridge. This results in assert in xics_alloc_block() as >> req_num is zero. >> >> This adds a check for MSI vectors number too. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> I posted recently a memory corruption fix, patch >> "spapr_pci: Fix number of returned vectors in ibm, change-msi". >> >> However it breaks QEMU's PCI bridge so here is a patch. >> >> I would prepare a patch to replace the one in agrag/ppc-next ad01ba7 >> but it has Cc: qemu-stable@nongnu.org in it so I am afraid it could make >> it to some other tree already (did not it?). >> >> Sorry for missing that. This is embarassing :( > > You're lucky - No, I am not. Found another bug, please revert this, I'll repost the patch. Sorry :( > the patch didn't get out of my queue yet. I've squashed this > patch into the previous, broken commit and qemu-stable will only get CC'ed > on the resulting, working patch. -- Alexey