From: Joel Fernandes <joelf@ti.com>
To: Jonathan Liu <net147@gmail.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] serial-getty service: Add linux as default TERM
Date: Sun, 4 May 2014 15:32:46 -0500 [thread overview]
Message-ID: <5366A3EE.1040707@ti.com> (raw)
In-Reply-To: <536613A5.3020003@gmail.com>
On 05/04/2014 05:17 AM, Jonathan Liu wrote:
> On 4/05/2014 9:36 AM, Joel Fernandes wrote:
>> In poky with systemd enabled, vt102 is selected for getty
>> causing user to experience a very crappy terminal. Default
>> TERM to linux.
>>
>> Signed-off-by: Joel Fernandes <joelf@ti.com>
>> ---
>> v2: Dropped PR bump
>>
>> .../systemd-serialgetty/serial-getty@.service | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
>> b/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
>> index 865de34..eb2280b 100644
>> --- a/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
>> +++ b/meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
>> @@ -20,6 +20,7 @@ Before=getty.target
>> IgnoreOnIsolate=yes
>> [Service]
>> +Environment="TERM=linux"
>> ExecStart=-/sbin/agetty --keep-baud %I @BAUDRATE@ $TERM
>> Type=idle
>> Restart=always
> I would prefer:
> Environment="TERM=xterm"
> ExecStart=-/sbin/agetty -8 --keep-baud %I @BAUDRATE@ $TERM
>
> "xterm" as it is much more widely supported than "linux". Also, PuTTY
> uses "xterm" by default.
> -8 to assume the tty is 8-bit clean and disable parity detection. I have
> had some issues where parity sometimes gets enabled even though the
> serial line is 8-bit clean and I end up with garbage on the serial
> terminal.
Fair enough, I tested and it works fine for me. Will submit a patch.
-Joel
next prev parent reply other threads:[~2014-05-04 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 23:36 [PATCH v2] serial-getty service: Add linux as default TERM Joel Fernandes
2014-05-04 10:17 ` Jonathan Liu
2014-05-04 20:32 ` Joel Fernandes [this message]
2014-05-05 2:31 ` Khem Raj
2014-05-05 2:37 ` Joel Fernandes
2014-05-05 2:51 ` Joel Fernandes
2014-05-05 3:02 ` Khem Raj
2014-05-05 15:31 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5366A3EE.1040707@ti.com \
--to=joelf@ti.com \
--cc=net147@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.