From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Benjamin Bara <bbara93@gmail.com>, lee@kernel.org
Cc: jonathanh@nvidia.com, treding@nvidia.com,
richard.leitner@linux.dev, benjamin.bara@skidata.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: tps6586x: use devm-based power off handler
Date: Tue, 21 Mar 2023 05:17:08 +0300 [thread overview]
Message-ID: <53675327-d708-d441-4cef-d493d0766911@collabora.com> (raw)
In-Reply-To: <20230320220345.1463687-2-bbara93@gmail.com>
On 3/21/23 01:03, Benjamin Bara wrote:
> +static int tps6586x_power_off_handler(struct sys_off_data *data)
> {
> - if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT))
> - return;
> + int ret;
Nit: "int ret" should be put after "struct tps6586x_dev" to adhere
canonical kernel coding style
> + struct device *tps6586x_dev = (struct device *)data->cb_data;
No need for casting of the void* type
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-03-21 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 22:03 [PATCH v2 0/2] mfd: tps6586x: register restart handler Benjamin Bara
2023-03-20 22:03 ` [PATCH v2 1/2] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-03-21 2:17 ` Dmitry Osipenko [this message]
2023-03-20 22:03 ` [PATCH v2 2/2] mfd: tps6586x: register restart handler Benjamin Bara
2023-03-21 2:07 ` Dmitry Osipenko
2023-03-21 7:46 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53675327-d708-d441-4cef-d493d0766911@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=jonathanh@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=richard.leitner@linux.dev \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.