From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhG9q-00011P-RT for qemu-devel@nongnu.org; Mon, 05 May 2014 06:30:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhG9l-0006AY-Tn for qemu-devel@nongnu.org; Mon, 05 May 2014 06:30:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhG9l-0006AK-KO for qemu-devel@nongnu.org; Mon, 05 May 2014 06:29:57 -0400 Message-ID: <5367680B.7060901@redhat.com> Date: Mon, 05 May 2014 12:29:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399280501-25512-1-git-send-email-pranavkumar@linaro.org> <5367609D.30601@suse.de> In-Reply-To: <5367609D.30601@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V4 6/6] target-arm: Implement kvm_arch_reset_vcpu() for KVM ARM64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Pranavkumar Sawargaonkar , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Anup Patel , patches@apm.com, robherring2@gmail.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org Il 05/05/2014 11:57, Andreas F=E4rber ha scritto: > Am 05.05.2014 11:01, schrieb Pranavkumar Sawargaonkar: >> To implement kvm_arch_reset_vcpu(), we simply re-init the VCPU >> using kvm_arm_vcpu_init() so that all registers of VCPU are set >> to their reset values by in-kernel KVM code. >> >> Signed-off-by: Pranavkumar Sawargaonkar >> Signed-off-by: Anup Patel >> --- >> target-arm/kvm64.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/target-arm/kvm64.c b/target-arm/kvm64.c >> index f7cc3ef..4855b4b 100644 >> --- a/target-arm/kvm64.c >> +++ b/target-arm/kvm64.c >> @@ -259,4 +259,8 @@ int kvm_arch_get_registers(CPUState *cs) >> >> void kvm_arch_reset_vcpu(CPUState *cs) >> { >> + /* Re-init VCPU so that all registers are set to >> + * their respective reset values. >> + */ >> + kvm_arm_vcpu_init(cs, 0x0); >> } >> > > CC'ing Paolo, who was about to drop kvm_arch_reset_vcpu(). No big deal, it will have a small conflict but the functionality will=20 remain in ARM (just renamed to kvm_arm_reset_vcpu and taking an ARMCPU*). Thanks for the heads up. Paolo