Re: [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> Input and output marshalling functions do it differently.  Change them
> to work the same: initialize the I/O visitor, use it, clean it up,
> initialize the dealloc visitor, use it, clean it up.
> 
> This delays dealloc visitor initialization in output marshalling
> functions, and input visitor cleanup in input marshalling functions.
> No functional change, but the latter will be convenient when I change
> the error handling.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/qapi-code-gen.txt   |  8 ++++----
>  scripts/qapi-commands.py | 27 ++++++++++++---------------
>  2 files changed, 16 insertions(+), 19 deletions(-)

Tracking what the changes do in the examples certainly made it easier to
review.  Thanks.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]