From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:58865 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755697AbaEEUw5 (ORCPT ); Mon, 5 May 2014 16:52:57 -0400 Message-ID: <5367FA1E.9030800@iki.fi> Date: Mon, 05 May 2014 23:52:46 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Dan Carpenter , kbuild@01.org CC: Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [linuxtv-samsung:for-v3.16 45/81] drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here? References: <20140505190256.GP4963@mwanda> In-Reply-To: <20140505190256.GP4963@mwanda> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 05.05.2014 22:02, Dan Carpenter wrote: > > tree: git://linuxtv.org/snawrocki/samsung.git for-v3.16 > head: 13b46c7a03adbcc347b77a13ed27066bc92d515c > commit: 192292403147877c7d5f737a3cc751ded397aef7 [45/81] [media] em28xx: add [2013:025f] PCTV tripleStick (292e) > > drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some parenthesis here? > drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: maybe use && instead of & > drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: add some parenthesis here? > drivers/media/tuners/si2157.c:44 si2157_cmd_execute() warn: maybe use && instead of & > > git remote add linuxtv-samsung git://linuxtv.org/snawrocki/samsung.git > git remote update linuxtv-samsung > git checkout 192292403147877c7d5f737a3cc751ded397aef7 > vim +47 drivers/media/dvb-frontends/si2168.c > > 845f3505 Antti Palosaari 2014-04-10 31 goto err_mutex_unlock; > 845f3505 Antti Palosaari 2014-04-10 32 } else if (ret != cmd->rlen) { > 845f3505 Antti Palosaari 2014-04-10 33 ret = -EREMOTEIO; > 845f3505 Antti Palosaari 2014-04-10 34 goto err_mutex_unlock; > 845f3505 Antti Palosaari 2014-04-10 35 } > 845f3505 Antti Palosaari 2014-04-10 36 > 845f3505 Antti Palosaari 2014-04-10 37 /* firmware ready? */ > 845f3505 Antti Palosaari 2014-04-10 38 if ((cmd->args[0] >> 7) & 0x01) > 845f3505 Antti Palosaari 2014-04-10 39 break; > 845f3505 Antti Palosaari 2014-04-10 40 } > 845f3505 Antti Palosaari 2014-04-10 41 > 845f3505 Antti Palosaari 2014-04-10 42 dev_dbg(&s->client->dev, "%s: cmd execution took %d ms\n", > 845f3505 Antti Palosaari 2014-04-10 43 __func__, > 845f3505 Antti Palosaari 2014-04-10 44 jiffies_to_msecs(jiffies) - > 845f3505 Antti Palosaari 2014-04-10 45 (jiffies_to_msecs(timeout) - TIMEOUT)); > 845f3505 Antti Palosaari 2014-04-10 46 > 845f3505 Antti Palosaari 2014-04-10 @47 if (!(cmd->args[0] >> 7) & 0x01) { > > This should be: if (!((md->args[0] >> 7) & 0x01)) { > Otherwise it is a precedence error where it does the negate before the > bitwise AND. That was already on my TODO list as daily media build test sparse warned it already http://hverkuil.home.xs4all.nl/logs/Monday.log I am waiting for media/master kernel upgrades from 3.15-rc1 as that kernel will hang whole machine when em28xx driver used (em28xx driver is USB bridge for those si2168 and si2157). regards Antti -- http://palosaari.fi/