From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WhQL6-0004AT-EM
	for qemu-devel@nongnu.org; Mon, 05 May 2014 17:22:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WhQL0-0002LH-DS
	for qemu-devel@nongnu.org; Mon, 05 May 2014 17:22:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35362)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WhQL0-0002L5-6E
	for qemu-devel@nongnu.org; Mon, 05 May 2014 17:22:14 -0400
Message-ID: <536800FD.3000708@redhat.com>
Date: Mon, 05 May 2014 23:22:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1398668558-16687-1-git-send-email-akong@redhat.com>
	<20140505165104.0d54b9f5@redhat.com>
In-Reply-To: <20140505165104.0d54b9f5@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated
 code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>, Amos Kong <akong@redhat.com>
Cc: armbru@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, mdroth@linux.vnet.ibm.com

Il 05/05/2014 22:51, Luiz Capitulino ha scritto:
> On Mon, 28 Apr 2014 15:02:35 +0800
> Amos Kong <akong@redhat.com> wrote:
>
>> Not a serious issue, but it's helpful if we can fix it.
>>
>> V2: split change of scripts/qapi-visit.py to a split patch,
>>     eat space by using a special char as Markus suggested
>> V3: update commitlog, update special string, fix of adding
>>     const replace string by pattern
>>
>> Amos Kong (3):
>>   qapi: fix coding style in parameters list
>>   qapi: add const prefix to 'char *' insider c_type()
>>   qapi: Suppress unwanted space between type and identifier
>
> Applied to the qmp branch.
>
> The last conflicts with another patch I applied to my tree (both
> are importing re module). I fixed it myself by dropping your import.
>

Did you address my comment at
http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg04445.html
while applying, too?

Paolo