From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1blp0188.outbound.protection.outlook.com [207.46.163.188]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5E5AF140300 for ; Tue, 6 May 2014 16:36:01 +1000 (EST) Message-ID: <5368811A.3060609@Freescale.com> Date: Tue, 6 May 2014 01:28:42 -0500 From: Emil Medve MIME-Version: 1.0 To: Scott Wood Subject: Re: [PATCH 5/6] powerpc/corenet: Add DPAA FMan support to the SoC device tree(s) References: <1397823693-27977-1-git-send-email-Shruti@Freescale.com> <1397823693-27977-5-git-send-email-Shruti@Freescale.com> <1398118442.1694.190.camel__272.432543761347$1398129129$gmane$org@snotra.buserror.net> <53661DAB.10808@Freescale.com> <1399332886.15726.161.camel@snotra.buserror.net> In-Reply-To: <1399332886.15726.161.camel@snotra.buserror.net> Content-Type: text/plain; charset="UTF-8" Cc: devicetree@vger.kernel.org, Kanetkar Shruti-B44454 , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Scott, On 05/05/2014 06:34 PM, Scott Wood wrote: > On Sun, 2014-05-04 at 05:59 -0500, Emil Medve wrote: >> Hello Scott, >> >> >> On 04/21/2014 05:14 PM, Scott Wood wrote: >>> On Fri, 2014-04-18 at 07:21 -0500, Shruti Kanetkar wrote: >>>> FMan 1 Gb/s MACs (dTSEC and mEMAC) have support for SGMII PHYs. >>>> Add support for the internal SerDes TBI PHYs >>>> >>>> Based on prior work by Andy Fleming >>>> >>>> Signed-off-by: Shruti Kanetkar >>>> --- >>>> arch/powerpc/boot/dts/fsl/b4860si-post.dtsi | 28 +++++ >>>> arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 51 +++++++++ >>>> arch/powerpc/boot/dts/fsl/p1023si-post.dtsi | 14 +++ >>>> arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 64 ++++++++++++ >>>> arch/powerpc/boot/dts/fsl/p3041si-post.dtsi | 64 ++++++++++++ >>>> arch/powerpc/boot/dts/fsl/p4080si-post.dtsi | 104 +++++++++++++++++++ >>>> arch/powerpc/boot/dts/fsl/p5020si-post.dtsi | 64 ++++++++++++ >>>> arch/powerpc/boot/dts/fsl/p5040si-post.dtsi | 128 +++++++++++++++++++++++ >>>> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 154 ++++++++++++++++++++++++++++ >>>> 9 files changed, 671 insertions(+) >>>> >>>> diff --git a/arch/powerpc/boot/dts/fsl/b4860si-post.dtsi b/arch/powerpc/boot/dts/fsl/b4860si-post.dtsi >>>> index cbc354b..45b0ff5 100644 >>>> --- a/arch/powerpc/boot/dts/fsl/b4860si-post.dtsi >>>> +++ b/arch/powerpc/boot/dts/fsl/b4860si-post.dtsi >>>> @@ -172,6 +172,34 @@ >>>> compatible = "fsl,b4860-rcpm", "fsl,qoriq-rcpm-2.0"; >>>> }; >>>> >>>> +/include/ "qoriq-fman3-0-1g-4.dtsi" >>>> +/include/ "qoriq-fman3-0-1g-5.dtsi" >>>> +/include/ "qoriq-fman3-0-10g-0.dtsi" >>>> +/include/ "qoriq-fman3-0-10g-1.dtsi" >>>> + fman@400000 { >>>> + ethernet@e8000 { >>>> + tbi-handle = <&tbi4>; >>>> + }; >>> >>> Binding needed >>> >>> Where is the "reg" for these unit addresses? >> >> As I said, the bulk of the FMan work comes from another team. Here we >> need just enough to hook up the MDIO and PHY nodes. > > Unit addresses must match reg. No reg, no unit address. We can add a 'reg' property, but we really don't want to clash with the team that is working on upstreaming the FMan/MAC bindings and drivers >> I'd really like to be able to make progress on this without waiting for that moment in time >> we can get the entire FMan binding in place > > Why is the fman binding such a big deal? > >>>> + mdio@e9000 { >>>> + tbi4: tbi-phy@8 { >>>> + reg = <0x8>; >>>> + device_type = "tbi-phy"; >>>> + }; >>>> + }; >>> >>> Binding needed for tbi-phy device_type >> >> I guess that's fair (BTW, you accepted tbi-phy nodes/device-type before >> without a binding) > > It's existing practice on eTSEC. FMan seemed like an opportunity to > avoid carrying cruft forward. The 1 Gb/s MDIO block is not FMan specific. As I said is the same block from eTSEC. That's part of the reason we're trying upstreaming this independent of the FMan stuff. So, don't think FMan, think MDIO >>> Why are we using device_type at all for this? >> >> That's what the upstream driver is looking for. > > Drivers should look for what the binding says -- not the other way > around. Yeah yeah. Nobody likes it, but the driver is/describes the de facto binding On a constructive note, the Ethernet PHY code doesn't do device tree based probing so no compatibles are used at all. So device_type is used to convey a TBI PHY >> Anyway, most days PHYs can be discovered so they don't use/need >> compatible properties. That's I guess part of the reason we don't have >> bindings for them PHY nodes > > I don't see why there couldn't be a compatible that describes the > standard programming interface. Because it can be detected at runtime and I guess stuff like that should stay out of the device tree. I'm using PCI as an analogy here >> However, what you can't discover is how they are wired to the MAC(s) so >> we still need some nodes in the device tree to convey that. Also, when >> looking for a specific kind of PHY, such as TBI, device_type works >> easier then parsing compatibles from various vendors or so > > Don't you find the TBI by following the tbi-handle property? When the MAC "attaches" to the PHY the tbi-handle is followed. But the MDIO/PHY code/driver(s) doesn't quite "see" the tbi-handle as it's outside the MDIO/PHY nodes > That said, > I don't object to having a way to label a PHY as attached via TBI if > that's useful. I'm giving a mild, non-nacking (given the history) > objection to using device_type for that (given other history). Personally, I think that TBI PHY support is a bit messy but I don't have bandwidth to deal with that. The TBI PHY should be handled as a regular PHY and right now is a special case Cheers, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Medve Subject: Re: [PATCH 5/6] powerpc/corenet: Add DPAA FMan support to the SoC device tree(s) Date: Tue, 6 May 2014 01:28:42 -0500 Message-ID: <5368811A.3060609@Freescale.com> References: <1397823693-27977-1-git-send-email-Shruti@Freescale.com> <1397823693-27977-5-git-send-email-Shruti@Freescale.com> <1398118442.1694.190.camel__272.432543761347$1398129129$gmane$org@snotra.buserror.net> <53661DAB.10808@Freescale.com> <1399332886.15726.161.camel@snotra.buserror.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1399332886.15726.161.camel@snotra.buserror.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Scott Wood Cc: devicetree@vger.kernel.org, Kanetkar Shruti-B44454 , "linuxppc-dev@lists.ozlabs.org" List-Id: devicetree@vger.kernel.org SGVsbG8gU2NvdHQsCgoKT24gMDUvMDUvMjAxNCAwNjozNCBQTSwgU2NvdHQgV29vZCB3cm90ZToK PiBPbiBTdW4sIDIwMTQtMDUtMDQgYXQgMDU6NTkgLTA1MDAsIEVtaWwgTWVkdmUgd3JvdGU6Cj4+ IEhlbGxvIFNjb3R0LAo+Pgo+Pgo+PiBPbiAwNC8yMS8yMDE0IDA1OjE0IFBNLCBTY290dCBXb29k IHdyb3RlOgo+Pj4gT24gRnJpLCAyMDE0LTA0LTE4IGF0IDA3OjIxIC0wNTAwLCBTaHJ1dGkgS2Fu ZXRrYXIgd3JvdGU6Cj4+Pj4gRk1hbiAxIEdiL3MgTUFDcyAoZFRTRUMgYW5kIG1FTUFDKSBoYXZl IHN1cHBvcnQgZm9yIFNHTUlJIFBIWXMuCj4+Pj4gQWRkIHN1cHBvcnQgZm9yIHRoZSBpbnRlcm5h bCBTZXJEZXMgVEJJIFBIWXMKPj4+Pgo+Pj4+IEJhc2VkIG9uIHByaW9yIHdvcmsgYnkgQW5keSBG bGVtaW5nIDxhZmxlbWluZ0BnbWFpbC5jb20+Cj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBTaHJ1 dGkgS2FuZXRrYXIgPFNocnV0aUBGcmVlc2NhbGUuY29tPgo+Pj4+IC0tLQo+Pj4+ICBhcmNoL3Bv d2VycGMvYm9vdC9kdHMvZnNsL2I0ODYwc2ktcG9zdC5kdHNpIHwgIDI4ICsrKysrCj4+Pj4gIGFy Y2gvcG93ZXJwYy9ib290L2R0cy9mc2wvYjRzaS1wb3N0LmR0c2kgICAgfCAgNTEgKysrKysrKysr Cj4+Pj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvcDEwMjNzaS1wb3N0LmR0c2kgfCAgMTQg KysrCj4+Pj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvcDIwNDFzaS1wb3N0LmR0c2kgfCAg NjQgKysrKysrKysrKysrCj4+Pj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvcDMwNDFzaS1w b3N0LmR0c2kgfCAgNjQgKysrKysrKysrKysrCj4+Pj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9m c2wvcDQwODBzaS1wb3N0LmR0c2kgfCAxMDQgKysrKysrKysrKysrKysrKysrKwo+Pj4+ICBhcmNo L3Bvd2VycGMvYm9vdC9kdHMvZnNsL3A1MDIwc2ktcG9zdC5kdHNpIHwgIDY0ICsrKysrKysrKysr Kwo+Pj4+ICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3A1MDQwc2ktcG9zdC5kdHNpIHwgMTI4 ICsrKysrKysrKysrKysrKysrKysrKysrCj4+Pj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wv dDQyNDBzaS1wb3N0LmR0c2kgfCAxNTQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+ ICA5IGZpbGVzIGNoYW5nZWQsIDY3MSBpbnNlcnRpb25zKCspCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0 IGEvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2ZzbC9iNDg2MHNpLXBvc3QuZHRzaSBiL2FyY2gvcG93 ZXJwYy9ib290L2R0cy9mc2wvYjQ4NjBzaS1wb3N0LmR0c2kKPj4+PiBpbmRleCBjYmMzNTRiLi40 NWIwZmY1IDEwMDY0NAo+Pj4+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvYjQ4NjBz aS1wb3N0LmR0c2kKPj4+PiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL2I0ODYwc2kt cG9zdC5kdHNpCj4+Pj4gQEAgLTE3Miw2ICsxNzIsMzQgQEAKPj4+PiAgCQljb21wYXRpYmxlID0g ImZzbCxiNDg2MC1yY3BtIiwgImZzbCxxb3JpcS1yY3BtLTIuMCI7Cj4+Pj4gIAl9Owo+Pj4+ICAK Pj4+PiArL2luY2x1ZGUvICJxb3JpcS1mbWFuMy0wLTFnLTQuZHRzaSIKPj4+PiArL2luY2x1ZGUv ICJxb3JpcS1mbWFuMy0wLTFnLTUuZHRzaSIKPj4+PiArL2luY2x1ZGUvICJxb3JpcS1mbWFuMy0w LTEwZy0wLmR0c2kiCj4+Pj4gKy9pbmNsdWRlLyAicW9yaXEtZm1hbjMtMC0xMGctMS5kdHNpIgo+ Pj4+ICsJZm1hbkA0MDAwMDAgewo+Pj4+ICsJCWV0aGVybmV0QGU4MDAwIHsKPj4+PiArCQkJdGJp LWhhbmRsZSA9IDwmdGJpND47Cj4+Pj4gKwkJfTsKPj4+Cj4+PiBCaW5kaW5nIG5lZWRlZAo+Pj4K Pj4+IFdoZXJlIGlzIHRoZSAicmVnIiBmb3IgdGhlc2UgdW5pdCBhZGRyZXNzZXM/Cj4+Cj4+IEFz IEkgc2FpZCwgdGhlIGJ1bGsgb2YgdGhlIEZNYW4gd29yayBjb21lcyBmcm9tIGFub3RoZXIgdGVh bS4gSGVyZSB3ZQo+PiBuZWVkIGp1c3QgZW5vdWdoIHRvIGhvb2sgdXAgdGhlIE1ESU8gYW5kIFBI WSBub2Rlcy4KPiAKPiBVbml0IGFkZHJlc3NlcyBtdXN0IG1hdGNoIHJlZy4gIE5vIHJlZywgbm8g dW5pdCBhZGRyZXNzLgoKV2UgY2FuIGFkZCBhICdyZWcnIHByb3BlcnR5LCBidXQgd2UgcmVhbGx5 IGRvbid0IHdhbnQgdG8gY2xhc2ggd2l0aCB0aGUKdGVhbSB0aGF0IGlzIHdvcmtpbmcgb24gdXBz dHJlYW1pbmcgdGhlIEZNYW4vTUFDIGJpbmRpbmdzIGFuZCBkcml2ZXJzCgo+PiBJJ2QgcmVhbGx5 IGxpa2UgdG8gYmUgYWJsZSB0byBtYWtlIHByb2dyZXNzIG9uIHRoaXMgd2l0aG91dCB3YWl0aW5n IGZvciB0aGF0IG1vbWVudCBpbiB0aW1lCj4+IHdlIGNhbiBnZXQgdGhlIGVudGlyZSBGTWFuIGJp bmRpbmcgaW4gcGxhY2UKPiAKPiBXaHkgaXMgdGhlIGZtYW4gYmluZGluZyBzdWNoIGEgYmlnIGRl YWw/Cj4gCj4+Pj4gKwkJbWRpb0BlOTAwMCB7Cj4+Pj4gKwkJCXRiaTQ6IHRiaS1waHlAOCB7Cj4+ Pj4gKwkJCQlyZWcgPSA8MHg4PjsKPj4+PiArCQkJCWRldmljZV90eXBlID0gInRiaS1waHkiOwo+ Pj4+ICsJCQl9Owo+Pj4+ICsJCX07Cj4+Pgo+Pj4gQmluZGluZyBuZWVkZWQgZm9yIHRiaS1waHkg ZGV2aWNlX3R5cGUKPj4KPj4gSSBndWVzcyB0aGF0J3MgZmFpciAoQlRXLCB5b3UgYWNjZXB0ZWQg dGJpLXBoeSBub2Rlcy9kZXZpY2UtdHlwZSBiZWZvcmUKPj4gd2l0aG91dCBhIGJpbmRpbmcpCj4g Cj4gSXQncyBleGlzdGluZyBwcmFjdGljZSBvbiBlVFNFQy4gIEZNYW4gc2VlbWVkIGxpa2UgYW4g b3Bwb3J0dW5pdHkgdG8KPiBhdm9pZCBjYXJyeWluZyBjcnVmdCBmb3J3YXJkLgoKVGhlIDEgR2Iv cyBNRElPIGJsb2NrIGlzIG5vdCBGTWFuIHNwZWNpZmljLiBBcyBJIHNhaWQgaXMgdGhlIHNhbWUg YmxvY2sKZnJvbSBlVFNFQy4gVGhhdCdzIHBhcnQgb2YgdGhlIHJlYXNvbiB3ZSdyZSB0cnlpbmcg dXBzdHJlYW1pbmcgdGhpcwppbmRlcGVuZGVudCBvZiB0aGUgRk1hbiBzdHVmZi4gU28sIGRvbid0 IHRoaW5rIEZNYW4sIHRoaW5rIE1ESU8KCj4+PiBXaHkgYXJlIHdlIHVzaW5nIGRldmljZV90eXBl IGF0IGFsbCBmb3IgdGhpcz8KPj4KPj4gVGhhdCdzIHdoYXQgdGhlIHVwc3RyZWFtIGRyaXZlciBp cyBsb29raW5nIGZvci4KPiAKPiBEcml2ZXJzIHNob3VsZCBsb29rIGZvciB3aGF0IHRoZSBiaW5k aW5nIHNheXMgLS0gbm90IHRoZSBvdGhlciB3YXkKPiBhcm91bmQuCgpZZWFoIHllYWguIE5vYm9k eSBsaWtlcyBpdCwgYnV0IHRoZSBkcml2ZXIgaXMvZGVzY3JpYmVzIHRoZSBkZSBmYWN0byBiaW5k aW5nCgpPbiBhIGNvbnN0cnVjdGl2ZSBub3RlLCB0aGUgRXRoZXJuZXQgUEhZIGNvZGUgZG9lc24n dCBkbyBkZXZpY2UgdHJlZQpiYXNlZCBwcm9iaW5nIHNvIG5vIGNvbXBhdGlibGVzIGFyZSB1c2Vk IGF0IGFsbC4gU28gZGV2aWNlX3R5cGUgaXMgdXNlZAp0byBjb252ZXkgYSBUQkkgUEhZCgo+PiAg QW55d2F5LCBtb3N0IGRheXMgUEhZcyBjYW4gYmUgZGlzY292ZXJlZCBzbyB0aGV5IGRvbid0IHVz ZS9uZWVkCj4+IGNvbXBhdGlibGUgcHJvcGVydGllcy4gVGhhdCdzIEkgZ3Vlc3MgcGFydCBvZiB0 aGUgcmVhc29uIHdlIGRvbid0IGhhdmUKPj4gYmluZGluZ3MgZm9yIHRoZW0gUEhZIG5vZGVzCj4g Cj4gSSBkb24ndCBzZWUgd2h5IHRoZXJlIGNvdWxkbid0IGJlIGEgY29tcGF0aWJsZSB0aGF0IGRl c2NyaWJlcyB0aGUKPiBzdGFuZGFyZCBwcm9ncmFtbWluZyBpbnRlcmZhY2UuCgpCZWNhdXNlIGl0 IGNhbiBiZSBkZXRlY3RlZCBhdCBydW50aW1lIGFuZCBJIGd1ZXNzIHN0dWZmIGxpa2UgdGhhdCBz aG91bGQKc3RheSBvdXQgb2YgdGhlIGRldmljZSB0cmVlLiBJJ20gdXNpbmcgUENJIGFzIGFuIGFu YWxvZ3kgaGVyZQoKPj4gSG93ZXZlciwgd2hhdCB5b3UgY2FuJ3QgZGlzY292ZXIgaXMgaG93IHRo ZXkgYXJlIHdpcmVkIHRvIHRoZSBNQUMocykgc28KPj4gd2Ugc3RpbGwgbmVlZCBzb21lIG5vZGVz IGluIHRoZSBkZXZpY2UgdHJlZSB0byBjb252ZXkgdGhhdC4gQWxzbywgd2hlbgo+PiBsb29raW5n IGZvciBhIHNwZWNpZmljIGtpbmQgb2YgUEhZLCBzdWNoIGFzIFRCSSwgZGV2aWNlX3R5cGUgd29y a3MKPj4gZWFzaWVyIHRoZW4gcGFyc2luZyBjb21wYXRpYmxlcyBmcm9tIHZhcmlvdXMgdmVuZG9y cyBvciBzbwo+IAo+IERvbid0IHlvdSBmaW5kIHRoZSBUQkkgYnkgZm9sbG93aW5nIHRoZSB0Ymkt aGFuZGxlIHByb3BlcnR5PwoKV2hlbiB0aGUgTUFDICJhdHRhY2hlcyIgdG8gdGhlIFBIWSB0aGUg dGJpLWhhbmRsZSBpcyBmb2xsb3dlZC4gQnV0IHRoZQpNRElPL1BIWSBjb2RlL2RyaXZlcihzKSBk b2Vzbid0IHF1aXRlICJzZWUiIHRoZSB0YmktaGFuZGxlIGFzIGl0J3MKb3V0c2lkZSB0aGUgTURJ Ty9QSFkgbm9kZXMKCj4gVGhhdCBzYWlkLAo+IEkgZG9uJ3Qgb2JqZWN0IHRvIGhhdmluZyBhIHdh eSB0byBsYWJlbCBhIFBIWSBhcyBhdHRhY2hlZCB2aWEgVEJJIGlmCj4gdGhhdCdzIHVzZWZ1bC4g IEknbSBnaXZpbmcgYSBtaWxkLCBub24tbmFja2luZyAoZ2l2ZW4gdGhlIGhpc3RvcnkpCj4gb2Jq ZWN0aW9uIHRvIHVzaW5nIGRldmljZV90eXBlIGZvciB0aGF0IChnaXZlbiBvdGhlciBoaXN0b3J5 KS4KClBlcnNvbmFsbHksIEkgdGhpbmsgdGhhdCBUQkkgUEhZIHN1cHBvcnQgaXMgYSBiaXQgbWVz c3kgYnV0IEkgZG9uJ3QgaGF2ZQpiYW5kd2lkdGggdG8gZGVhbCB3aXRoIHRoYXQuIFRoZSBUQkkg UEhZIHNob3VsZCBiZSBoYW5kbGVkIGFzIGEgcmVndWxhcgpQSFkgYW5kIHJpZ2h0IG5vdyBpcyBh IHNwZWNpYWwgY2FzZQoKCkNoZWVycywKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlz dHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMt ZGV2