From: Jeff Liu <jeff.liu@oracle.com>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] xfs: remove shared supberlock feature checking
Date: Tue, 06 May 2014 15:48:43 +0800 [thread overview]
Message-ID: <536893DB.7050705@oracle.com> (raw)
In-Reply-To: <1399348559-19889-6-git-send-email-david@fromorbit.com>
On 05/06 2014 11:55 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> We reject any filesystem that is mounted with this feature bit set,
> so we don't need to check for it anywhere else. Remove the function
> for checking if the feature bit is set and any code that uses it.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_fsops.c | 2 --
> fs/xfs/xfs_sb.c | 3 ++-
> fs/xfs/xfs_sb.h | 17 ++++-------------
> 3 files changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
> index b099799..97886a7 100644
> --- a/fs/xfs/xfs_fsops.c
> +++ b/fs/xfs/xfs_fsops.c
> @@ -84,8 +84,6 @@ xfs_fs_geometry(
> XFS_FSOP_GEOM_FLAGS_IALIGN : 0) |
> (xfs_sb_version_hasdalign(&mp->m_sb) ?
> XFS_FSOP_GEOM_FLAGS_DALIGN : 0) |
> - (xfs_sb_version_hasshared(&mp->m_sb) ?
> - XFS_FSOP_GEOM_FLAGS_SHARED : 0) |
Just a trivial comments, now the XFS_FSOP_GEOM_FLAGS_SHARED is useless, so
we can remove it from fs/xfs/xfs.h.
Otherwise, looks good to me.
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Cheers,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-06 7:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 3:55 [PATCH 0/5] xfs: sanitise supberlock feature bit support Dave Chinner
2014-05-06 3:55 ` [PATCH 1/5] xfs: make superblock version checks reflect reality Dave Chinner
2014-05-06 8:29 ` Christoph Hellwig
2014-05-06 8:39 ` Dave Chinner
2014-05-06 3:55 ` [PATCH 2/5] xfs: keep sb_bad_features2 the same a sb_features2 Dave Chinner
2014-05-06 8:20 ` Christoph Hellwig
2014-05-06 3:55 ` [PATCH 3/5] xfs: turn NLINK feature on by default Dave Chinner
2014-05-06 8:15 ` Christoph Hellwig
2014-05-06 9:06 ` Dave Chinner
2014-05-06 3:55 ` [PATCH 4/5] xfs: don't need dirv2 checks anymore Dave Chinner
2014-05-06 8:16 ` Christoph Hellwig
2014-05-06 8:45 ` Dave Chinner
2014-05-06 3:55 ` [PATCH 5/5] xfs: remove shared supberlock feature checking Dave Chinner
2014-05-06 7:48 ` Jeff Liu [this message]
2014-05-06 8:02 ` Dave Chinner
2014-05-06 8:18 ` Christoph Hellwig
2014-05-06 8:28 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2014-05-16 23:00 [PATCH 0/5 V2] xfs: sanitise superblock feature bit support Dave Chinner
2014-05-16 23:00 ` [PATCH 5/5] xfs: remove shared supberlock feature checking Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536893DB.7050705@oracle.com \
--to=jeff.liu@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.