From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Better clean-up of pvmove failures in a cluster
Date: Tue, 06 May 2014 09:54:19 +0200 [thread overview]
Message-ID: <5368952B.6040404@redhat.com> (raw)
In-Reply-To: <1399325884.1503.5.camel@f16>
Dne 5.5.2014 23:38, Jonathan Brassow napsal(a):
> Hi,
>
> I don't see any reason why the following patch would be bad, but I'd
> like to hear from others first. In essence, I'm just trying to improve
> the error code path. This seems to improve things for pvmove when a
> node in the cluster is not running 'cmirrord' as it should. However, it
> doesn't clean everything up when attempting to create a full cluster
> mirror LV. So there might still be some work left after this.
I've already tried to add some initial recovery support for error path.
If you take a look into the upstream libdm-deptee code - there is already
dnode->activated list for recovery path - which track just newly introduced
devices.
The problem is however much more complicated - it should work as transaction,
since multiple device may get changed - and all changes should be
reverted properly.
>
> brassow
>
> activation: Remove empty DM devices when table fails to load.
There is postprocessing routine which should cleanup any left
empty entries in the table.
I'm currently working on more generic solution.
Zdenek
prev parent reply other threads:[~2014-05-06 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 21:38 [PATCH] Better clean-up of pvmove failures in a cluster Jonathan Brassow
2014-05-06 7:54 ` Zdenek Kabelac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5368952B.6040404@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.