All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6sabred: Add PFUZE100 PMIC support
Date: Tue, 06 May 2014 10:07:48 +0200	[thread overview]
Message-ID: <53689854.9070904@denx.de> (raw)
In-Reply-To: <CAOMZO5BWZtEMchwL4v21VEdcz1Wta9rP_2nRBxOMUQrAkuX1PQ@mail.gmail.com>

Hi Fabio,

On 05/05/2014 18:08, Fabio Estevam wrote:
> On Mon, May 5, 2014 at 12:56 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Mon, May 5, 2014 at 12:32 PM, Tim Harvey <tharvey@gateworks.com> wrote:
>>
>>> Hi Fabio,
>>>
>>> Yes, I think Stefano is correct in that power_init_board() is the
>>> right place to put pmic init. He asked me to do that to my recent
>>> series as well and it worked fine. Note that in that series I do have
>>> a patch that will rename pmic_init() for the PFUZE100 to
>>> power_pfuze100_init() [1]. I'm hoping that will make it in soon.
>>
>> Thanks, Tim.
>>
>> Stefano,
>>
>> It seems that I need to wait for Tim's series to be applied, otherwise
>> there will be a build breakage.
> 
> In the meantime I converted the current patch to using
> power_init_board() instead, but this causes problems:
> 
> => pmic list
> PMIC devices:
> name: PFUZE100_PMIC bus: I2C_1
> => pmic PFUZE100_PMIC dump
> PMIC: PFUZE100_PMIC
> wait_for_sr_state: failed sr=81 cr=a0 state=2020
> i2c_init_transfer: failed for chip 0x8 retry=0
> wait_for_sr_state: failed sr=81 cr=a0 state=2020
> i2c_init_transfer: failed for chip 0x8 retry=1
> wait_for_sr_state: failed sr=81 cr=a0 state=2020
> i2c_init_transfer: failed for chip 0x8 retry=2
> i2c_init_transfer: give up i2c_regs=021a0000
> PMIC: Registers dump failed
> 
> With the previous misc_init_r() approach the 'dump' command worked correctly.
> 
> Any suggestions?
> 

Checkin in arch/arm/lib/board.c, I see that power_init_board() is called
quite early (that makes sense, as power can be necessary to go on). Can
you try moving  power_init_board() later ?
Anyway, I2C is already set (by board_init, called previously) and malloc
is also available.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-05-06  8:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-04 19:14 [U-Boot] [PATCH] mx6sabred: Add PFUZE100 PMIC support Fabio Estevam
2014-05-05 14:00 ` Otavio Salvador
2014-05-05 14:04   ` Fabio Estevam
2014-05-05 14:29 ` Stefano Babic
2014-05-05 15:32   ` Tim Harvey
2014-05-05 15:56     ` Fabio Estevam
2014-05-05 16:08       ` Fabio Estevam
2014-05-06  8:07         ` Stefano Babic [this message]
2014-05-06 13:22           ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53689854.9070904@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.