From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhgtF-0000SR-UB for qemu-devel@nongnu.org; Tue, 06 May 2014 11:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhgtA-0007IQ-UD for qemu-devel@nongnu.org; Tue, 06 May 2014 11:02:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhgtA-0007HR-Lw for qemu-devel@nongnu.org; Tue, 06 May 2014 11:02:36 -0400 Message-ID: <5368F987.6030602@redhat.com> Date: Tue, 06 May 2014 09:02:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140502135218.31383.90270.stgit@fimbulvetr.bsc.es> <20140506130740.GA17717@irqsave.net> In-Reply-To: <20140506130740.GA17717@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LnoUlWMil7RSxN4VIC5q8X1NREGwlg2iU" Subject: Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= Cc: Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LnoUlWMil7RSxN4VIC5q8X1NREGwlg2iU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/06/2014 07:07 AM, Beno=C3=AEt Canet wrote: >=20 > common.json being included in block-core.json and in qapi-schema.json i= t > quickly lead some code being generated in double and the compilation to= choke. >=20 > What do you think would be the best solution to fix this ? > (Fix the generator ? Make include ignore second inclusion of the same f= ile ?) I'd argue for the latter - update the parser and the documentation to state that if a file is included twice, the second inclusion does nothing. Obviously, the testsuite needs enhancement to test the solution, as well. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LnoUlWMil7RSxN4VIC5q8X1NREGwlg2iU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTaPmHAAoJEKeha0olJ0NqNqwH/RAPHIny1XvZW9xkT3oFdLQ/ MuQBpaVukIhy2c5VNRy6CmQBHKH/GID/MQfh93zUDuhNZUc9RH5Fw8HUOBhR2JfL UFhMALBUdww2AgNkFz3TR6KTOtvj9QldP+sYRp77JKgZB0nhqZAymM+w/KWy3+En nzGRVkcFBnst7pHaswM4T1FLlVnYbBiz+OfxiIsdnGycfqClqAPjgaEOjVdvxNtT oGOX9NDswPBKZbmkXJrm/r0f+a1k9IuE6TUnzK4OkSlfXNLrWDFjrXnrxcumWc8Z HINMFMq3T//75hIJqh6qeH8/UBqW/IleGw7GvtRGzffQemqkzxPc/O+8HX5x/l0= =zrMZ -----END PGP SIGNATURE----- --LnoUlWMil7RSxN4VIC5q8X1NREGwlg2iU--