All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: ath10k: kernel BUG at net/core/skbuff.c:147
Date: Tue, 06 May 2014 09:50:24 -0700	[thread overview]
Message-ID: <536912D0.5020005@candelatech.com> (raw)
In-Reply-To: <CAHqTa-22VFGSKGBq0BA+12GPz1yA87SUoYZ3J2z+RLt0VK_T4g@mail.gmail.com>

On 05/06/2014 03:00 AM, Avery Pennarun wrote:
> Here's another crash I'm getting sometimes.
> 
> This is with 3.2.26 kernel, mindspeed c2000 (armv7l) processor, and
> backports built using kvalo's ath-next branch, with commit
> v3.15-rc1-237-gd9bc4b9, firmware 10.1.467.2-1.
> 
> This didn't happen with the previous driver version I was using,
> ath10k-stable-3.11-8.

> Someone at work has partially analyzed it as follows:
> 
> """
> There is a change between the last backports and the new one involving how MSDU
> sk_buffs are handled. It appears to be copying a chain of skbs to the
> tail of the first skb.
> 
> The panic happens when there is insufficient headroom, which this
> function doesn't change.
> So though interesting, this doesn't appear to be involved in the panic.
> 
> [This patch seems to be from greearb, cc'd.]

Before my patch, MSDUs were just dropped, so they must have been
fairly rare and/or un-tested in most work loads.

Can you find which part of the ath10k driver is calling the code
that calls the skb_push, ie using gdb and the 'l *(ath10k_htt_txrx_compl_task+0x7ec)' command?


Thanks,
Ben



-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

      reply	other threads:[~2014-05-06 16:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 10:00 ath10k: kernel BUG at net/core/skbuff.c:147 Avery Pennarun
2014-05-06 16:50 ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536912D0.5020005@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=apenwarr@gmail.com \
    --cc=ath10k@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.