Re: [PATCH] xen: don't flush the TLB on grant unmap for auto-translated guests

[David Vrabel <david.vrabel@citrix.com>]

On 06/05/14 17:37, Roger Pau Monne wrote:
> For auto-translated guests the p2m code will do the necessary TLB
> flushes, so there's no need to perform any TLB flushes in generic
> grant table code.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Tim Deegan <tim@xen.org>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> ---
>  xen/common/grant_table.c |   12 ++++++++----
>  1 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index 107b000..a2a857f 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -1099,7 +1099,8 @@ gnttab_unmap_grant_ref(
>              guest_handle_add_offset(uop, 1);
>          }
>  
> -        flush_tlb_mask(current->domain->domain_dirty_cpumask);
> +        if ( !paging_mode_external(current->domain) )
> +            flush_tlb_mask(current->domain->domain_dirty_cpumask);

Introduce

void gnttab_flush_tlb(struct domain *d)
{
    if ( !paging_mode_external(d) )
        flush_tlb_mask(d->domain_dirty_cpumask);
}

?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel