Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

On 05/06/2014 10:55 AM, Luiz Capitulino wrote:
> On Tue, 06 May 2014 08:55:52 -0600
> Eric Blake <eblake@redhat.com> wrote:
> 
>>> Eventually, we might want to have if/defs and whatnot. But having a master
>>> file seems a reasonable first step to me. I actually thought this was the
>>> intention. Unless I got it wrong, of course.
>>
>> Ifdefs may be a bit much.  If we add them, then we can worry about
>> explicit include guards, the same as the C preprocessor.  But for now,
>> I'd be perfectly fine with a followup patch that includes a file's
>> contents exactly once, no matter how many times it is included (that is,
>> act as if include guards were implicitly present, since we lack
>> conditionals, so include files are currently idempotent).
> 
> OK. Does it make sense to merge the current series without that
> modification?

Yes.  Idempotent inclusion as a followup patch is just fine; and the
current series is still useful for some clients without waiting for
idempotent inclusion to make it useful for even more clients.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]