From: Eric Blake <eblake@redhat.com>
To: Chris Friesen <chris.friesen@windriver.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libvirt] qemu leaving unix sockets behind after VM is shut down
Date: Tue, 06 May 2014 11:25:00 -0600 [thread overview]
Message-ID: <53691AEC.8030800@redhat.com> (raw)
In-Reply-To: <5368F719.7070308@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On 05/06/2014 08:52 AM, Chris Friesen wrote:
> Yes, I am in fact using OpenStack/libvirt, and did eventually track down
> libvirt as the code that was cleaning up the monitor socket.
>
> Even so, I think this sort of change would be valid in qemu itself. qemu
> created the files, so really it should be up to qemu to delete them when
> it's done with them.
>
> They're not usable for anything with qemu not running, so there's no
> good reason to leave them laying around.
In the case of sVirt with SELinux labeling, it's often the case that
libvirt has to pre-create the file (as qemu itself is prevented from
creating the file itself) - that is also an argument for libvirt doing
the cleanup.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-06 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 20:34 [Qemu-devel] qemu leaving unix sockets behind after VM is shut down Chris Friesen
2014-05-06 13:39 ` Stefan Hajnoczi
2014-05-06 14:29 ` [Qemu-devel] [libvirt] " Daniel P. Berrange
2014-05-06 14:52 ` [Qemu-devel] " Chris Friesen
2014-05-06 17:25 ` Eric Blake [this message]
2014-05-13 13:24 ` [Qemu-devel] [libvirt] " Ján Tomko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53691AEC.8030800@redhat.com \
--to=eblake@redhat.com \
--cc=chris.friesen@windriver.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.