From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whk35-0004o0-Du for qemu-devel@nongnu.org; Tue, 06 May 2014 14:25:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whk30-0005O8-Fy for qemu-devel@nongnu.org; Tue, 06 May 2014 14:25:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whk30-0005O1-86 for qemu-devel@nongnu.org; Tue, 06 May 2014 14:24:58 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s46Ht729004347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 6 May 2014 13:55:07 -0400 Message-ID: <536921FA.8040902@redhat.com> Date: Tue, 06 May 2014 11:55:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399320099-32457-1-git-send-email-mreitz@redhat.com> <20140506114958.GE15810@stefanha-thinkpad.redhat.com> <5368D518.9000007@redhat.com> <53692010.1000302@redhat.com> In-Reply-To: <53692010.1000302@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Hhpklfp6cFX1AR2jL983TonXEhSaICDk" Subject: Re: [Qemu-devel] [PATCH] block/raw-posix: Fall back to SEEK_HOLE/SEEK_DATA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Hhpklfp6cFX1AR2jL983TonXEhSaICDk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/06/2014 11:46 AM, Max Reitz wrote: >=20 > Okay, then I'll put the functionality in own functions and reverse the > order in v2 while keeping the fallback idea, as I think there may exist= > systems where the reverse of what this patch tries to fix is true: > SEEK_HOLE/SEEK_DATA is not supported, but FIEMAP is. Correct - Linux implemented FIEMAP long before SEEK_HOLE, so there is a range of kernels where FIEMAP is all you have. It is only non-Linux where you will have SEEK_HOLE in isolation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9Hhpklfp6cFX1AR2jL983TonXEhSaICDk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTaSH6AAoJEKeha0olJ0Nqi4YH/1b0j9a8xeShrgcB8KDGb1ZN 5nF2p/h+HLmXvcDQj0SV6NrT309XtlbBAMFEpZNg1m/LcrOFMa3IWVgUUCUmm3p3 9hGI7homEYZUenMyEpjrd6zm4ELllbXCgEodcp2VWT6qyRNSJr7sBDCU9UB7JQAC fqW6kYR2YwWiVAZ726qiojchUD5s7Mg97vKyRD2OLNSYvCkQ571UhwkspAk4UA7a KSscpU8ABlWFEwt1ojGXkcWZR2g/ibyuFfPUGrPPMGNowULvjUR0SSHGCKuIQvdM 8fdH4EKPauAC+632L6G4cH4cT+z1uaGQ9tkhppA8GHR0D5WTrYa7lsq25LVjjyw= =/I+h -----END PGP SIGNATURE----- --9Hhpklfp6cFX1AR2jL983TonXEhSaICDk--