All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra: relax the check on BR2_TOOLCHAIN_BUILDROOT_VENDOR
Date: Tue, 06 May 2014 21:14:44 +0200	[thread overview]
Message-ID: <536934A4.6010206@mind.be> (raw)
In-Reply-To: <20140506195920.697ab409@free-electrons.com>

On 06/05/14 19:59, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle (Essensium/Mind),
> 
> On Tue,  6 May 2014 18:27:47 +0200, Arnout Vandecappelle
> (Essensium/Mind) wrote:
>> 65c2400f introduced BR2_TOOLCHAIN_BUILDROOT_VENDOR and a check that it
>> is not empty or 'unknown'. However, when a .config file from before
>> that commit exists, this makes it impossible to run *config in order
>> to set a value. Catch-22.
>>
>> To break the cycle, remove the check when running one of the config
>> targets.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>> ---
>>  package/Makefile.in | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/Makefile.in b/package/Makefile.in
>> index c34a3bf..da8b768 100644
>> --- a/package/Makefile.in
>> +++ b/package/Makefile.in
>> @@ -26,7 +26,8 @@ else
>>  TARGET_VENDOR = buildroot
>>  endif
>>  
>> -# Sanity checks
>> +# Sanity checks - but not when we try to reconfigure
>> +ifeq ($(filter menuconfig xconfig gconfig nconfig config defconfig oldconfig silentoldconfig %_defconfig,$(MAKECMDGOALS)),)
> 
> What about using $(noconfig_targets) here, like is done in the main
> Makefile?

 D'oh, silly me. This patch is not necessary.

 I still have http://patchwork.ozlabs.org/patch/316667/ rebased on top of
master, and that patch reads .config even for the *config targets.

 So I've marked this patch as Not Applicable in patchwork.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-05-06 19:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 16:27 [Buildroot] [PATCH] infra: relax the check on BR2_TOOLCHAIN_BUILDROOT_VENDOR Arnout Vandecappelle
2014-05-06 17:59 ` Thomas Petazzoni
2014-05-06 19:14   ` Arnout Vandecappelle [this message]
2014-05-06 21:04     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536934A4.6010206@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.