From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames
Date: Tue, 06 May 2014 14:28:54 -0600 [thread overview]
Message-ID: <53694606.9040007@redhat.com> (raw)
In-Reply-To: <53693F40.5040308@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On 05/06/2014 02:00 PM, Max Reitz wrote:
>>
>> -drive
>> file='json:{"driver":"qcow2","file.filename":"foo","backing.file.driver":"raw"}',backing.file.driver=qcow2
>>
>>
>> looks like it specifies conflicting backing.file.driver options.
>> Passing true means that qdict_join silently overwrites the value in
>> options to instead be the value in the json string; passing false means
>> you could flag the user error.
>
> Yes, you're right; I'll change it.
And of course, bonus points if you enhance the testsuite to provoke the
error and prove we detect it :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-06 20:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 19:30 [Qemu-devel] [PATCH 0/4] block: Allow JSON filenames Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 1/4] qdict: Add qdict_join() Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 2/4] check-qdict: Add test for qdict_join() Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames Max Reitz
2014-05-06 19:57 ` Eric Blake
2014-05-06 20:00 ` Max Reitz
2014-05-06 20:28 ` Eric Blake [this message]
2014-05-06 20:29 ` Max Reitz
2014-05-07 8:39 ` Kevin Wolf
2014-05-08 17:54 ` Max Reitz
2014-05-06 19:30 ` [Qemu-devel] [PATCH 4/4] iotests: Add test for the JSON protocol Max Reitz
2014-05-06 20:04 ` Eric Blake
2014-05-06 20:04 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53694606.9040007@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.