From: Jens Axboe <axboe@kernel.dk>
To: Stoo Davies <sdavies@skyera.com>, fio@vger.kernel.org
Subject: Re: Meta verification regression starting with fio 2.1.5
Date: Tue, 06 May 2014 19:10:15 -0600 [thread overview]
Message-ID: <536987F7.6030709@kernel.dk> (raw)
In-Reply-To: <53697FED.5060001@skyera.com>
On 2014-05-06 18:35, Stoo Davies wrote:
> On 05/06/2014 02:59 PM, Jens Axboe wrote:
>> 2.1.5 did indeed change when the IO was logged for verification, so that
>> does explain why it fails for you now. That's a problem.
>>
>> Can you try with this patch? I'm not going to commit it yet, I want to
>> carefully audit all paths to ensure we also unlog or trim an io_piece,
>> if we don't fully complete it.
>>
> 10 loops through the powerfail test and all the hosts are still happy.
> Looks good to me, thanks for the fast response.
Thanks a lot for reporting it, I have now committed a patch that is
basically what I sent you, but catches the partial completion case as well.
--
Jens Axboe
prev parent reply other threads:[~2014-05-07 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 18:25 Meta verification regression starting with fio 2.1.5 Stoo Davies
2014-05-06 21:59 ` Jens Axboe
2014-05-07 0:35 ` Stoo Davies
2014-05-07 1:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536987F7.6030709@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=sdavies@skyera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.