From: "Sun, Daisy" <daisy.sun@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Debugfs disable RPS boost and idle
Date: Tue, 06 May 2014 18:50:11 -0700 [thread overview]
Message-ID: <53699153.7000608@intel.com> (raw)
In-Reply-To: <20140506055101.GE5519@nuc-i3427.alporthouse.com>
"So can you not tracepoints to give EI results for up/down signals and
filter out the noise? ", Do you mean I don't need the debugfs at all?
For developer, he/she is able to trace anything including the point of
Turbo algorithm adjustment(+n/-n).
But as a black box, validation will not see the cause but only the result.
Boost / Idle function will set RP frequency to Max / Min, turbo
algorithm will +n / -n depends on our implementation.
My intention is to block the disturbance of Boost /Idle, then the RPS
frequency change can only cause bye Turbo algorithm.
- Daisy
On 5/5/2014 10:51 PM, Chris Wilson wrote:
> On Mon, May 05, 2014 at 02:50:27PM -0700, Daisy Sun wrote:
>> RP frequency request is affected by 2 modules: normal turbo
>> algorithm and RPS boost algorithm. By adding RPS boost algorithm
>> to the mix, the final frequency becomes relatively unpredictable.
>> Add a switch to enable/disable RPS boost functionality. When
>> disabled, RP frequency will follow the normal turbo algorithm only.
>>
>> Intention: when boost and idle are disabled, we have a clear vision
>> of turbo algorithm. It‘s very helpful to verify if the turbo
>> algorithm is working as expected.
>> Without debugfs hooks, the RPS boost or idle may kick in at
>> anytime and any circumstances.
> The algorithm is still not the same as you "intended". So can you not
> tracepoints to give EI results for up/down signals and filter out the
> noise?
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-05-07 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 21:50 [PATCH v3] drm/i915: Debugfs disable RPS boost and idle Daisy Sun
2014-05-06 5:51 ` Chris Wilson
2014-05-07 1:50 ` Sun, Daisy [this message]
2014-05-10 5:07 ` Deepak S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53699153.7000608@intel.com \
--to=daisy.sun@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.