From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seung-Woo Kim Subject: Re: [PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY Date: Wed, 07 May 2014 14:14:36 +0900 Message-ID: <5369C13C.3080506@samsung.com> References: <1399217181-26442-1-git-send-email-djkurtz@chromium.org> <1399217181-26442-3-git-send-email-djkurtz@chromium.org> Reply-To: sw0312.kim@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset="euc-kr" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1399217181-26442-3-git-send-email-djkurtz@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Kurtz Cc: Kukjin Kim , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , linux-samsung-soc@vger.kernel.org, marcheu@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org SGkgRGFuaWVsLAoKT24gMjAxNLPiIDA1v/kgMDXAzyAwMDoyNiwgRGFuaWVsIEt1cnR6IHdyb3Rl Ogo+IE1peGVyIGhhcmR3YXJlIHN1cHBvcnRzIG9mZnNldHRpbmcgZG1hIGZyb20gc3RhcnQgb2Yg c291cmNlIGJ1ZmZlciB1c2luZwo+IHRoZSBNWFJfR1JQX1NYWSByZWdpc3Rlci4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBEYW5pZWwgS3VydHogPGRqa3VydHpAY2hyb21pdW0ub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19taXhlci5jIHwgOCArKystLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19taXhlci5jIGIvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9leHlub3NfbWl4ZXIuYwo+IGluZGV4IDQ3NWViNDkuLjQwY2YzOWIgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfbWl4ZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX21peGVyLmMKPiBAQCAtNTI5LDEzICs1MjksMTEg QEAgc3RhdGljIHZvaWQgbWl4ZXJfZ3JhcGhfYnVmZmVyKHN0cnVjdCBtaXhlcl9jb250ZXh0ICpj dHgsIGludCB3aW4pCj4gIAo+ICAJZHN0X3hfb2Zmc2V0ID0gd2luX2RhdGEtPmNydGNfeDsKPiAg CWRzdF95X29mZnNldCA9IHdpbl9kYXRhLT5jcnRjX3k7Cj4gKwlzcmNfeF9vZmZzZXQgPSB3aW5f ZGF0YS0+ZmJfeDsKPiArCXNyY195X29mZnNldCA9IHdpbl9kYXRhLT5mYl95Owo+ICAKPiAgCS8q IGNvbnZlcnRpbmcgZG1hIGFkZHJlc3MgYmFzZSBhbmQgc291cmNlIG9mZnNldCAqLwo+IC0JZG1h X2FkZHIgPSB3aW5fZGF0YS0+ZG1hX2FkZHIKPiAtCQkrICh3aW5fZGF0YS0+ZmJfeCAqIHdpbl9k YXRhLT5icHAgPj4gMykKPiAtCQkrICh3aW5fZGF0YS0+ZmJfeSAqIHdpbl9kYXRhLT5mYl93aWR0 aCAqIHdpbl9kYXRhLT5icHAgPj4gMyk7Cj4gLQlzcmNfeF9vZmZzZXQgPSAwOwo+IC0Jc3JjX3lf b2Zmc2V0ID0gMDsKPiArCWRtYV9hZGRyID0gd2luX2RhdGEtPmRtYV9hZGRyOwoKQmFzaWNhbGx5 LCB5b3UgYXJlIHJpZ2h0IGFuZCBzb3VyY2Ugb2Zmc2V0IHJlZ2lzdGVyIGNhbiBiZSB1c2VkLiBC dXQKYmVjYXVzZSBvZiBsaW1pdGF0aW9uIG9mIHJlc29sdXRpb24gZm9yIG1peGVyIHVwIHRvIDE5 MjB4MTA4MCwgSQpjb25zaWRlcmVkIG1vZGlmaWVkIHNvcnVjZSBkbWEgYWRkcmVzcyB0byBzZXQg b25lIGZyYW1lIGJ1ZmZlciwgd2hpY2ggaXMKYmlnZ2VyIHRoYW4gMTkyMHgxMDgwLCBvbiB0byBi b3RoIGZpbWQgYW5kIGhkbWkuCgpSZWdhcmRzLAotIFNldW5nLVdvbyBLaW0KCj4gIAo+ICAJaWYg KHdpbl9kYXRhLT5zY2FuX2ZsYWdzICYgRFJNX01PREVfRkxBR19JTlRFUkxBQ0UpCj4gIAkJY3R4 LT5pbnRlcmxhY2UgPSB0cnVlOwo+IAoKLS0gClNldW5nLVdvbyBLaW0KU2Ftc3VuZyBTb2Z0d2Fy ZSBSJkQgQ2VudGVyCi0tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: sw0312.kim@samsung.com (Seung-Woo Kim) Date: Wed, 07 May 2014 14:14:36 +0900 Subject: [PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY In-Reply-To: <1399217181-26442-3-git-send-email-djkurtz@chromium.org> References: <1399217181-26442-1-git-send-email-djkurtz@chromium.org> <1399217181-26442-3-git-send-email-djkurtz@chromium.org> Message-ID: <5369C13C.3080506@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel, On 2014? 05? 05? 00:26, Daniel Kurtz wrote: > Mixer hardware supports offsetting dma from start of source buffer using > the MXR_GRP_SXY register. > > Signed-off-by: Daniel Kurtz > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index 475eb49..40cf39b 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -529,13 +529,11 @@ static void mixer_graph_buffer(struct mixer_context *ctx, int win) > > dst_x_offset = win_data->crtc_x; > dst_y_offset = win_data->crtc_y; > + src_x_offset = win_data->fb_x; > + src_y_offset = win_data->fb_y; > > /* converting dma address base and source offset */ > - dma_addr = win_data->dma_addr > - + (win_data->fb_x * win_data->bpp >> 3) > - + (win_data->fb_y * win_data->fb_width * win_data->bpp >> 3); > - src_x_offset = 0; > - src_y_offset = 0; > + dma_addr = win_data->dma_addr; Basically, you are right and source offset register can be used. But because of limitation of resolution for mixer up to 1920x1080, I considered modified soruce dma address to set one frame buffer, which is bigger than 1920x1080, on to both fimd and hdmi. Regards, - Seung-Woo Kim > > if (win_data->scan_flags & DRM_MODE_FLAG_INTERLACE) > ctx->interlace = true; > -- Seung-Woo Kim Samsung Software R&D Center -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbaEGFOn (ORCPT ); Wed, 7 May 2014 01:14:43 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:12682 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbaEGFOk (ORCPT ); Wed, 7 May 2014 01:14:40 -0400 MIME-version: 1.0 Content-type: text/plain; charset=EUC-KR X-AuditID: cbfee68d-b7f4e6d000004845-44-5369c13e2b4a Content-transfer-encoding: 8BIT Message-id: <5369C13C.3080506@samsung.com> Date: Wed, 07 May 2014 14:14:36 +0900 From: Seung-Woo Kim Reply-to: sw0312.kim@samsung.com User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 To: Daniel Kurtz Cc: Inki Dae , Kukjin Kim , Joonyoung Shim , Kyungmin Park , David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, seanpaul@chromium.org, marcheu@chromium.org, Seung-Woo Kim Subject: Re: [PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY References: <1399217181-26442-1-git-send-email-djkurtz@chromium.org> <1399217181-26442-3-git-send-email-djkurtz@chromium.org> In-reply-to: <1399217181-26442-3-git-send-email-djkurtz@chromium.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsWyRsSkQNfuYGawwflteha9504yWTTOmM9q ceXrezaLSfcnsFi8uHeRxaJ3wVU2i7NNb9gtNj2+xmpxedccNosZ5/cxWcw79JvR4u6Gs4wW Mya/ZHPg9ZjdcJHFY/u3B6we97uPM3lsXlLv0bdlFaPH501yAWxRXDYpqTmZZalF+nYJXBnL Nz9mK+jmqbgxcSpTA+Mrzi5GTg4JAROJ543zGSFsMYkL99azgdhCAksZJfYdsoOp2b3yAnMX IxdQfDqjxOTzj5hAErwCghI/Jt9j6WLk4GAWkJc4cikbJMwsoCEx9fVpRoj614wSM5ZOYYOo 15I4s+cM2DIWAVWJBzM6WEFsNgEdif1LfrNCLFaQuDLxGDvITFGBMImdm9NBTBEBdYlfN5xA RjILLGOWuLz1FNhIYQFbie62F+wQrfUSsxvngMU5BVwlNpz+yQ7SICEwlUNiy94ZTBB7BSS+ TT4EdrOEgKzEpgPMED9KShxccYNlAqP4LCSfzUL4bBaSzxYwMq9iFE0tSC4oTkovMtQrTswt Ls1L10vOz93ECIzm0/+e9e5gvH3A+hBjMtDGicxSosn5wGSQVxJvaGxmZGFqYmpsZG5pRpqw kjhv0sOkICGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2MG94WTbx4JPTsk6o/lUtPsHEr27qV 22/aWHuGPTtg+cYb0dxePbJh7vsV+5313qQKNK7SUdadtnDnlC9Rx5QfaPfqpXfJ2C3xNDLo KjsgXTDvS+OWzqWzuOYq8Pt2fzHfLLON8aDEFLnZkasstKL0arRX1Wm9nKy0/cCpj4x3jj+5 wH8qbMIzJZbijERDLeai4kQAHf/QX/wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOKsWRmVeSWpSXmKPExsVy+t9jQV27g5nBBpv2qVr0njvJZNE4Yz6r xZWv79ksJt2fwGLx4t5FFoveBVfZLM42vWG32PT4GqvF5V1z2CxmnN/HZDHv0G9Gi7sbzjJa zJj8ks2B12N2w0UWj+3fHrB63O8+zuSxeUm9R9+WVYwenzfJBbBFNTDaZKQmpqQWKaTmJeen ZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gBdqqRQlphTChQKSCwuVtK3wzQh NMRN1wKmMULXNyQIrsfIAA0krGHMWL75MVtBN0/FjYlTmRoYX3F2MXJySAiYSOxeeYEZwhaT uHBvPVsXIxeHkMB0RonJ5x8xgSR4BQQlfky+x9LFyMHBLCAvceRSNkiYWUBDYurr04wQ9a8Z JWYsncIGUa8lcWbPGUYQm0VAVeLBjA5WEJtNQEdi/5LfYLaQgILElYnH2EFmigqESezcnA5i igioS/y64QQykllgGbPE5a2nwEYKC9hKdLe9YIdorZeY3TgHLM4p4Cqx4fRP9gmMgrOQXDoL 4dJZSC5dwMi8ilE0tSC5oDgpPddIrzgxt7g0L10vOT93EyM4WTyT3sG4qsHiEKMAB6MSD6/F 24xgIdbEsuLK3EOMEhzMSiK8Nvsyg4V4UxIrq1KL8uOLSnNSiw8xJgP9OZFZSjQ5H5jI8kri DY1NzIwsjcwNLYyMzUkTVhLnPdhqHSgkkJ5YkpqdmlqQWgSzhYmDU6qBMU3VZdvC2mlWbax7 zrs3xGY8jGFvTnR2UX3c2ZtxdEvkbS4Gvc2rupLW/itm/7pju8WmeFU2sahlte39n/JdFr5l U/ZgmZyh7qCgwlG14MA7OXNp54i5m2qXB/sYNjWkvZG9pLL6nfvbJ5UX1213dXww603i8QcS zj/Tj/1cWp8vqPPtL+cTJZbijERDLeai4kQA7JNUpVoDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 2014³â 05¿ù 05ÀÏ 00:26, Daniel Kurtz wrote: > Mixer hardware supports offsetting dma from start of source buffer using > the MXR_GRP_SXY register. > > Signed-off-by: Daniel Kurtz > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index 475eb49..40cf39b 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -529,13 +529,11 @@ static void mixer_graph_buffer(struct mixer_context *ctx, int win) > > dst_x_offset = win_data->crtc_x; > dst_y_offset = win_data->crtc_y; > + src_x_offset = win_data->fb_x; > + src_y_offset = win_data->fb_y; > > /* converting dma address base and source offset */ > - dma_addr = win_data->dma_addr > - + (win_data->fb_x * win_data->bpp >> 3) > - + (win_data->fb_y * win_data->fb_width * win_data->bpp >> 3); > - src_x_offset = 0; > - src_y_offset = 0; > + dma_addr = win_data->dma_addr; Basically, you are right and source offset register can be used. But because of limitation of resolution for mixer up to 1920x1080, I considered modified soruce dma address to set one frame buffer, which is bigger than 1920x1080, on to both fimd and hdmi. Regards, - Seung-Woo Kim > > if (win_data->scan_flags & DRM_MODE_FLAG_INTERLACE) > ctx->interlace = true; > -- Seung-Woo Kim Samsung Software R&D Center --