From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
Eric Paris <eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] fanotify.7: adjust description of the fanotify queue
Date: Wed, 07 May 2014 10:18:56 +0200 [thread overview]
Message-ID: <5369EC70.1040009@gmail.com> (raw)
In-Reply-To: <1399401666-24806-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
On 05/06/2014 08:41 PM, Heinrich Schuchardt wrote:
> In http://www.spinics.net/lists/linux-man/msg05624.html
> Jan Kara proposed to clarify the deletion of events from the fanotify queue
> and the occurence of ENOENT when writing to the fanotify file descriptor.
Thanks, Heinrich. I've applied and added a Reviewed-by: from Jan.
I've also pushed a few other fixes to the pages. I'd be happy if you could
take a look at these commits in particular, to check I injected no errors:
3253bbc
a4cd12a
There are three other (larger) commits as well, but they are essentially
wording and formatting fixes.
Cheers,
Michael
> Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
> ---
> man7/fanotify.7 | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/man7/fanotify.7 b/man7/fanotify.7
> index 182d2d7..bce70ac 100644
> --- a/man7/fanotify.7
> +++ b/man7/fanotify.7
> @@ -113,10 +113,11 @@ whether permission for a file access shall be granted.
> For these events, the recipient must write a response which decides whether
> access is granted or not.
>
> -Queue entries for notification events are removed when the event has been
> +An event is removed from the event queue of the fanotify group when it has been
> read.
> -Queue entries for permission events are removed when the permission
> -decision has been taken by writing to the fanotify file descriptor.
> +Permission events that have been read are kept in an internal list of the
> +fanotify group until either a permission decision has been taken by writing to
> +the fanotify file descriptor or the fanotify file descriptor is closed.
> .SS Reading fanotify events
> Calling
> .BR read (2)
> @@ -400,8 +401,8 @@ in the response structure is not valid.
> The file descriptor
> .I fd
> in the response structure is not valid.
> -This might occur because the file was already deleted by another thread or
> -process.
> +This may occur when a response for the permission event already has been
> +written before.
> .SH VERSIONS
> The fanotify API was introduced in version 2.6.36 of the Linux kernel and
> enabled in version 2.6.37.
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-07 8:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 13:51 fanotify man pages for review Michael Kerrisk (man-pages)
2014-04-29 13:51 ` Michael Kerrisk (man-pages)
2014-05-03 9:24 ` Michael Kerrisk (man-pages)
2014-05-05 18:07 ` Jan Kara
[not found] ` <20140505180706.GH23927-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2014-05-06 4:57 ` Michael Kerrisk (man-pages)
2014-05-06 4:57 ` Michael Kerrisk (man-pages)
[not found] ` <53686BA4.6050505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-06 18:41 ` [PATCH 1/1] fanotify.7: adjust description of the fanotify queue Heinrich Schuchardt
[not found] ` <1399401666-24806-1-git-send-email-xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
2014-05-06 19:51 ` Jan Kara
2014-05-07 8:18 ` Michael Kerrisk (man-pages) [this message]
[not found] ` <5369EC70.1040009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-07 19:02 ` Heinrich Schuchardt
[not found] ` <536A8344.50804-Mmb7MZpHnFY@public.gmane.org>
2014-05-07 19:59 ` Michael Kerrisk (man-pages)
[not found] ` <535FAE78.5050404-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-07 19:15 ` fanotify man pages for review Michael Kerrisk (man-pages)
2014-05-07 19:15 ` Michael Kerrisk (man-pages)
2014-05-14 10:36 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5369EC70.1040009@gmail.com \
--to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xypron.glpk-Mmb7MZpHnFY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.