From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kai Huang <kai.huang@linux.intel.com>
Subject: Re: [PATCH] x86/MCE: bypass uninitialized vcpu in vMCE
	injection
Date: Wed, 07 May 2014 16:27:50 +0800
Message-ID: <5369EE86.7080900@linux.intel.com>
References: <1399447758-11798-1-git-send-email-kai.huang@linux.intel.com>
	<536A09B3020000780000FB5A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <536A09B3020000780000FB5A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.z.zhang@intel.com, jinsong.liu@alibaba-inc.com, dongxiao.xu@intel.com, kevin.tian@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


On 05/07/2014 04:23 PM, Jan Beulich wrote:
>>>> On 07.05.14 at 09:29, <kai.huang@linux.intel.com> wrote:
>> --- a/xen/arch/x86/cpu/mcheck/vmce.c
>> +++ b/xen/arch/x86/cpu/mcheck/vmce.c
>> @@ -356,6 +356,10 @@ int inject_vmce(struct domain *d, int vcpu)
>>           if ( vcpu != VMCE_INJECT_BROADCAST && vcpu != v->vcpu_id )
>>               continue;
>>   
>> +        /* In case of broadcasting, don't inject to uninitialized VCPU */
>> +        if ( vcpu == VMCE_INJECT_BROADCAST && !v->is_initialised )
>> +            continue;
>> +
> Conceptually fine, but mechanically in need of improvement: Please
> fold the check with the previous one, to avoid checking for
> VMCE_INJECT_BROADCAST twice.
>
> I'd do this as
>
>          if ( vcpu != VMCE_INJECT_BROADCAST ? vcpu != v->vcpu_id
>                                             : !v->is_initialised )
>              continue;
Thanks for comments. In this case, is it OK to you to add below comments 
just before the if statement? I think it's better to keep the comments 
somewhere.

	/* In case of broadcasting, don't inject to uninitialized VCPU */
	if ( vcpu != VMCE_INJECT_BROADCAST ? vcpu != v->vcpu_id
                                            : !v->is_initialised )
             continue;

Thanks,
-Kai
>
> but if you prefer some other style (like nested if/else), that would
> be fine with me too.
>
> Also please don't forget to also Cc the second x86/MCE maintainer.
>
> Jan
>