All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hu Yaohui <loki2441@gmail.com>, Abel Gordon <abel@stratoscale.com>
Cc: Bandan Das <bsd@redhat.com>, kvm <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Muli Ben-Yehuda <muli@stratoscale.com>
Subject: Re: KVM Nested L2 guest startup problems
Date: Wed, 07 May 2014 10:58:24 +0200	[thread overview]
Message-ID: <5369F5B0.7050307@redhat.com> (raw)
In-Reply-To: <CAHqbYQuv73Wm_9p-_yhYn5C5K9Ag+8Az+sJ_-WEnk9u9Z586Ww@mail.gmail.com>

Il 04/05/2014 18:33, Hu Yaohui ha scritto:
>> I experienced a similar problem that was related to nested code
>> having some bugs related to apicv and other new vmx features.
>>
>> For example, the code enabled posted interrupts to run L2 even when the
>> feature was not exposed to L1 and L1 didn't use it.
>>
>> Try changing prepare_vmcs02  to force disabling posted_interrupts,
>> code should looks like:
>>
>> ....
>> ....
>> exec_control = vmcs12->pin_based_vm_exec_control;
>> exec_control |= vmcs_config.pin_based_exec_ctrl;
>> exec_control &= ~(PIN_BASED_VMX_PREEMPTION_TIMER|PIN_BASED_POSTED_INTR);
>> vmcs_write32(PIN_BASED_VM_EXEC_CONTROL, exec_control);
>> ....
>> ...
>>
>> and also
>>
>> ...
>> ...
>> exec_control &= ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES |
>>      SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY |
>>      SECONDARY_EXEC_APIC_REGISTER_VIRT |
>>      SECONDARY_EXEC_PAUSE_LOOP_EXITING);

PLE should be left enabled, I think.

Apart from that, I'll change the suggestion into a patch.

Thanks!

Paolo

  reply	other threads:[~2014-05-07  8:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02  1:43 KVM Nested L2 guest startup problems Hu Yaohui
2014-05-02  9:53 ` Paolo Bonzini
2014-05-02 15:17   ` Hu Yaohui
2014-05-02 15:52     ` Paolo Bonzini
2014-05-02 17:07       ` Hu Yaohui
2014-05-02 18:39         ` Bandan Das
2014-05-02 20:11           ` Hu Yaohui
2014-05-04 14:57             ` Abel Gordon
2014-05-04 16:33               ` Hu Yaohui
2014-05-07  8:58                 ` Paolo Bonzini [this message]
2014-05-07 11:16                   ` Abel Gordon
2014-05-07 11:37                     ` Paolo Bonzini
2014-05-07 11:40                       ` Paolo Bonzini
2014-05-07 15:30                         ` Abel Gordon
2014-05-07 15:41                           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5369F5B0.7050307@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=abel@stratoscale.com \
    --cc=bsd@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loki2441@gmail.com \
    --cc=muli@stratoscale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.