From: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
To: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
'Wolfram Sang' <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/5] i2c: st: Make of_device_id array const
Date: Wed, 7 May 2014 11:05:04 +0200 [thread overview]
Message-ID: <5369F740.5010308@st.com> (raw)
In-Reply-To: <022601cf69d2$ef8ba9f0$cea2fdd0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hi Jingoo,
On 05/07/2014 11:01 AM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 8720161..95b94767 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -847,7 +847,7 @@ static int st_i2c_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id st_i2c_match[] = {
> +static const struct of_device_id st_i2c_match[] = {
> { .compatible = "st,comms-ssc-i2c", },
> { .compatible = "st,comms-ssc4-i2c", },
> {},
>
Thanks!
Maxime
next prev parent reply other threads:[~2014-05-07 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 8:54 [PATCH 1/5] i2c: ocores: Make of_device_id array const Jingoo Han
[not found] ` <022101cf69d1$f1311200$d3933600$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 8:57 ` [PATCH 2/5] i2c: pxa: " Jingoo Han
[not found] ` <022201cf69d2$5fcc0ad0$1f642070$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-09 23:52 ` Haojian Zhuang
2014-05-07 8:58 ` [PATCH 3/5] i2c: riic: " Jingoo Han
2014-05-07 9:00 ` [PATCH 5/5] i2c: wmt: " Jingoo Han
2014-05-07 9:01 ` [PATCH 4/5] i2c: st: " Jingoo Han
[not found] ` <022601cf69d2$ef8ba9f0$cea2fdd0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-07 9:05 ` Maxime Coquelin [this message]
2014-05-07 9:30 ` [PATCH 1/5] i2c: ocores: " Peter Korsgaard
2014-05-14 16:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5369F740.5010308@st.com \
--to=maxime.coquelin-qxv4g6hh51o@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.