From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>,
Hani Benhabiles <kroosec@gmail.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.
Date: Wed, 07 May 2014 13:01:12 +0200 [thread overview]
Message-ID: <536A1278.1070506@redhat.com> (raw)
In-Reply-To: <20140505143330.0d9794ab@redhat.com>
Il 05/05/2014 20:33, Luiz Capitulino ha scritto:
>> + data = object_property_get_qobject(obj, info->name, NULL);
>> + if (!data) {
>> + list = list->next;
>> + continue;
You could use object_property_print and get rid of a relatively large
amount of code.
Apart from this, the patch is definitely useful.
Paolo
next prev parent reply other threads:[~2014-05-07 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398594570-14015-1-git-send-email-kroosec@gmail.com>
2014-05-05 18:33 ` [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand Luiz Capitulino
2014-05-07 11:01 ` Paolo Bonzini [this message]
2014-05-11 12:06 ` Hani Benhabiles
2014-05-07 15:39 ` Andreas Färber
2014-05-11 12:16 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A1278.1070506@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=kroosec@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.